Skip to content

SYCL runtime wrapper: add memcpy support. #141647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

SYCL runtime wrapper: add memcpy support. #141647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cebbad9
SYCL runtime wrapper: add memcpy support.
silee2 May 22, 2025
2530407
Merge branch 'main' into syclMemcpy
charithaintc May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mlir/lib/ExecutionEngine/SyclRuntimeWrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
//
//===----------------------------------------------------------------------===//

#include <CL/sycl.hpp>
#include <level_zero/ze_api.h>
#include <sycl/ext/oneapi/backend/level_zero.hpp>
#include <sycl/sycl.hpp>

#ifdef _WIN32
#define SYCL_RUNTIME_EXPORT __declspec(dllexport)
Expand Down Expand Up @@ -81,8 +81,7 @@ static void *allocDeviceMemory(sycl::queue *queue, size_t size, bool isShared) {
memPtr = sycl::aligned_alloc_shared(64, size, getDefaultDevice(),
getDefaultContext());
} else {
memPtr = sycl::aligned_alloc_device(64, size, getDefaultDevice(),
getDefaultContext());
memPtr = sycl::aligned_alloc_device(64, size, *queue);
}
if (memPtr == nullptr) {
throw std::runtime_error("mem allocation failed!");
Expand Down Expand Up @@ -208,3 +207,8 @@ mgpuModuleUnload(ze_module_handle_t module) {

catchAll([&]() { L0_SAFE_CALL(zeModuleDestroy(module)); });
}

extern "C" SYCL_RUNTIME_EXPORT void
mgpuMemcpy(void *dst, void *src, size_t sizeBytes, sycl::queue *queue) {
catchAll([&]() { queue->memcpy(dst, src, sizeBytes).wait(); });
}
53 changes: 53 additions & 0 deletions mlir/test/Integration/GPU/SYCL/gpu-memcpy-addf32-to-spirv.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(gpu-async-region),spirv-attach-target{ver=v1.0 caps=Addresses,Int64,Kernel},convert-gpu-to-spirv{use-64bit-index=true},gpu.module(spirv.module(spirv-lower-abi-attrs,spirv-update-vce)),func.func(llvm-request-c-wrappers),convert-scf-to-cf,convert-cf-to-llvm,convert-arith-to-llvm,convert-math-to-llvm,convert-func-to-llvm,gpu-to-llvm{use-bare-pointers-for-kernels=true},gpu-module-to-binary,expand-strided-metadata,lower-affine,finalize-memref-to-llvm,reconcile-unrealized-casts)' \
// RUN: | mlir-runner \
// RUN: --shared-libs=%mlir_sycl_runtime \
// RUN: --shared-libs=%mlir_runner_utils \
// RUN: --entry-point-result=void \
// RUN: | FileCheck %s

module @add attributes {gpu.container_module} {
memref.global "private" constant @__constant_2x2x2xf32_0 : memref<2x2x2xf32> = dense<[[[1.1, 2.2], [3.3, 4.4]], [[5.5, 6.6], [7.7, 8.8 ]]]>
memref.global "private" constant @__constant_2x2x2xf32 : memref<2x2x2xf32> = dense<[[[1.2, 2.3], [4.5, 5.8]], [[7.2, 8.3], [10.5, 11.8]]]>
func.func @main() {
%0 = memref.get_global @__constant_2x2x2xf32 : memref<2x2x2xf32>
%1 = memref.get_global @__constant_2x2x2xf32_0 : memref<2x2x2xf32>
%2 = call @test(%0, %1) : (memref<2x2x2xf32>, memref<2x2x2xf32>) -> memref<2x2x2xf32>
%cast = memref.cast %2 : memref<2x2x2xf32> to memref<*xf32>
call @printMemrefF32(%cast) : (memref<*xf32>) -> ()
memref.dealloc %2 : memref<2x2x2xf32>
return
}
func.func private @printMemrefF32(memref<*xf32>)
func.func @test(%arg0: memref<2x2x2xf32>, %arg1: memref<2x2x2xf32>) -> memref<2x2x2xf32> {
%c2 = arith.constant 2 : index
%c1 = arith.constant 1 : index
%memref = gpu.alloc () : memref<2x2x2xf32>
gpu.memcpy %memref, %arg0 : memref<2x2x2xf32>, memref<2x2x2xf32>
%memref_0 = gpu.alloc () : memref<2x2x2xf32>
gpu.memcpy %memref_0, %arg1 : memref<2x2x2xf32>, memref<2x2x2xf32>
%memref_1 = gpu.alloc () : memref<2x2x2xf32>
gpu.launch_func @test_kernel::@test_kernel blocks in (%c2, %c2, %c2) threads in (%c1, %c1, %c1) args(%memref : memref<2x2x2xf32>, %memref_0 : memref<2x2x2xf32>, %memref_1 : memref<2x2x2xf32>)
%alloc = memref.alloc() : memref<2x2x2xf32>
gpu.memcpy %alloc, %memref_1 : memref<2x2x2xf32>, memref<2x2x2xf32>
gpu.dealloc %memref_1 : memref<2x2x2xf32>
gpu.dealloc %memref_0 : memref<2x2x2xf32>
gpu.dealloc %memref : memref<2x2x2xf32>
return %alloc : memref<2x2x2xf32>
}
gpu.module @test_kernel attributes {spirv.target_env = #spirv.target_env<#spirv.vce<v1.0, [Addresses, Int64, Kernel], []>, api=OpenCL, #spirv.resource_limits<>>} {
gpu.func @test_kernel(%arg0: memref<2x2x2xf32>, %arg1: memref<2x2x2xf32>, %arg2: memref<2x2x2xf32>) kernel attributes {gpu.known_block_size = array<i32: 1, 1, 1>, gpu.known_grid_size = array<i32: 2, 2, 2>, spirv.entry_point_abi = #spirv.entry_point_abi<>} {
%0 = gpu.block_id x
%1 = gpu.block_id y
%2 = gpu.block_id z
%3 = memref.load %arg0[%0, %1, %2] : memref<2x2x2xf32>
%4 = memref.load %arg1[%0, %1, %2] : memref<2x2x2xf32>
%5 = arith.addf %3, %4 : f32
memref.store %5, %arg2[%0, %1, %2] : memref<2x2x2xf32>
gpu.return
}
}
// CHECK: [2.3, 4.5]
// CHECK: [7.8, 10.2]
// CHECK: [12.7, 14.9]
// CHECK: [18.2, 20.6]
}
Loading