[tools] Allow RegClass/Bank in update_givaluetracking_test_checks.py #141727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script previously assumed an underscore after the :
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-testing-tools Author: Pierre van Houtryve (Pierre-vh) ChangesThe script previously assumed an underscore after the : Full diff: https://github.com/llvm/llvm-project/pull/141727.diff 3 Files Affected:
diff --git a/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir b/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir
index b04b376414cd9..197364c4b6b5f 100644
--- a/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir
+++ b/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir
@@ -20,7 +20,7 @@ body: |
; CHECK-NEXT: %4:_ KnownBits:???????????????????????????????? SignBits:1
%0:gpr32 = COPY $w0
%1:_(s32) = COPY %0
- %named:_(s64) = G_ZEXT %1
+ %named:gpr64(s64) = G_ZEXT %1
%3:_(s32), %4:_(s32) = G_UNMERGE_VALUES %named(s64)
$w0 = COPY %3(s32)
$w1 = COPY %4(s32)
diff --git a/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir.expected b/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir.expected
index c5b08bd47de81..dabcd508dd5eb 100644
--- a/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir.expected
+++ b/llvm/test/tools/UpdateTestChecks/update_givaluetracking_test_checks/Inputs/const.mir.expected
@@ -18,12 +18,12 @@ body: |
; Note: This comment should not be removed, the check lines below should be updated
; CHECK-LABEL: name: @Test2
; CHECK-NEXT: %1:_ KnownBits:???????????????????????????????? SignBits:1
- ; CHECK-NEXT: %named:_ KnownBits:00000000000000000000000000000000???????????????????????????????? SignBits:32
+ ; CHECK-NEXT: %named:gpr64 KnownBits:00000000000000000000000000000000???????????????????????????????? SignBits:32
; CHECK-NEXT: %3:_ KnownBits:???????????????????????????????? SignBits:1
; CHECK-NEXT: %4:_ KnownBits:00000000000000000000000000000000 SignBits:32
%0:gpr32 = COPY $w0
%1:_(s32) = COPY %0
- %named:_(s64) = G_ZEXT %1
+ %named:gpr64(s64) = G_ZEXT %1
%3:_(s32), %4:_(s32) = G_UNMERGE_VALUES %named(s64)
$w0 = COPY %3(s32)
$w1 = COPY %4(s32)
diff --git a/llvm/utils/update_givaluetracking_test_checks.py b/llvm/utils/update_givaluetracking_test_checks.py
index 3a8f5395e8eb3..49b068ac7bef0 100755
--- a/llvm/utils/update_givaluetracking_test_checks.py
+++ b/llvm/utils/update_givaluetracking_test_checks.py
@@ -22,7 +22,7 @@
VT_FUNCTION_RE = re.compile(
r"\s*name:\s*@(?P<func>[A-Za-z0-9_-]+)"
- r"(?P<body>(\s*%[0-9a-zA-Z_]+:_\s*KnownBits:[01?]+\sSignBits:[0-9]+$)+)",
+ r"(?P<body>(\s*%[0-9a-zA-Z_]+:[A-Za-z0-9_-]+\s*KnownBits:[01?]+\sSignBits:[0-9]+$)+)",
flags=(re.X | re.M),
)
|
arsenm
approved these changes
May 28, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
…lvm#141727) The script previously assumed an underscore after the :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script previously assumed an underscore after the :