Skip to content

[Sanitizer] xfail sanitizer_set_report_path_test.cpp on android #142184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ellishg
Copy link
Contributor

@ellishg ellishg commented May 30, 2025

XFAIL android to fix lit test broken by #141820

https://lab.llvm.org/buildbot/#/builders/186/builds/9498

FileCheck error: '' is empty.

For some reason nothing is printed on android. I'm not sure how to run this locally, so I'm xfailing it to fix the bots.

@llvmbot
Copy link
Member

llvmbot commented May 30, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Ellis Hoag (ellishg)

Changes

XFAIL android to fix lit test broken by #141820

https://lab.llvm.org/buildbot/#/builders/186/builds/9498

> FileCheck error: '<stdin>' is empty.

For some reason nothing is printed on android. I'm not sure how to run this locally, so I'm xfailing it to fix the bots.


Full diff: https://github.com/llvm/llvm-project/pull/142184.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp (+3)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
index 9d7ed80b44ccb..2b0f170365e19 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
@@ -3,6 +3,9 @@
 // RUN: %env HOME=%t.homedir TMPDIR=%t.tmpdir %run %t 2>%t.err | FileCheck %s
 // RUN: FileCheck %s --input-file=%t.err --check-prefix=ERROR
 
+// For some reason stdout is empty on android.
+// XFAIL: android
+
 #include <sanitizer/common_interface_defs.h>
 #include <stdio.h>
 #include <string.h>

@ellishg ellishg requested a review from fmayer May 30, 2025 17:30
@teresajohnson
Copy link
Contributor

Ok to XFAIL temporarily but if this seems like a regression then the original PR should be reverted unless a fix is imminent.

@fmayer
Copy link
Contributor

fmayer commented May 30, 2025

I don't feel like we should XFAIL if we don't know what's going on.

@ellishg
Copy link
Contributor Author

ellishg commented May 30, 2025

The PR change the test from checking the strings with assert() in the executable to checking the output of printf(). I'm wondering if android tests can use printf, or if something else is going on.

@ellishg
Copy link
Contributor Author

ellishg commented May 30, 2025

I think #142207 could be a true fix

@ellishg ellishg closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants