[libcxxabi][test] Check that all copied files are synced between llvm and libcxxabi #142262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and libcxxabi This patch expands the list of files we check to all the ones that are copied via `cp-to-llvm.sh`.
|
@llvm/pr-subscribers-libcxxabi Author: Michael Buch (Michael137) ChangesThis patch expands the list of files we check to all the ones that are copied via Full diff: https://github.com/llvm/llvm-project/pull/142262.diff 1 Files Affected:
diff --git a/libcxxabi/test/itanium_demangle_matches_llvm.sh.test b/libcxxabi/test/itanium_demangle_matches_llvm.sh.test
index 31371d121fbdd..55e389bdd7210 100644
--- a/libcxxabi/test/itanium_demangle_matches_llvm.sh.test
+++ b/libcxxabi/test/itanium_demangle_matches_llvm.sh.test
@@ -1,6 +1,20 @@
-# This test diffs the ItaniumDemangle.h header in libcxxabi and LLVM to ensure
-# that they are the same.
+# This test diffs the various headers synced by cp-to-llvm.sh
+# between libcxxabi and LLVM to ensure that they are the same.
# RUN: tail -n +3 %{libcxxabi}/src/demangle/ItaniumDemangle.h > %t.libcxxabi_demangle
# RUN: tail -n +3 %{llvm}/include/llvm/Demangle/ItaniumDemangle.h > %t.llvm_demangle
# RUN: diff %t.libcxxabi_demangle %t.llvm_demangle
+
+# RUN: tail -n +3 %{libcxxabi}/src/demangle/ItaniumNodes.def > %t.libcxxabi_nodes
+# RUN: tail -n +3 %{llvm}/include/llvm/Demangle/ItaniumNodes.def > %t.llvm_nodes
+# RUN: diff %t.libcxxabi_nodes %t.llvm_nodes
+
+# RUN: tail -n +3 %{libcxxabi}/src/demangle/StringViewExtras.h > %t.libcxxabi_extras
+# RUN: tail -n +3 %{llvm}/include/llvm/Demangle/StringViewExtras.h > %t.llvm_extras
+# RUN: diff %t.libcxxabi_extras %t.llvm_extras
+
+# RUN: tail -n +3 %{libcxxabi}/src/demangle/Utility.h > %t.libcxxabi_utility
+# RUN: tail -n +3 %{llvm}/include/llvm/Demangle/Utility.h > %t.llvm_utility
+# RUN: diff %t.libcxxabi_utility %t.llvm_utility
+
+# RUN: diff %{libcxxabi}/test/DemangleTestCases.inc %{llvm}/include/llvm/Testing/Demangle/DemangleTestCases.inc
|
boomanaiden154
approved these changes
May 31, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/17168 Here is the relevant piece of the build log for the reference |
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
… and libcxxabi (llvm#142262) This patch expands the list of files we check to all the ones that are copied via `cp-to-llvm.sh`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch expands the list of files we check to all the ones that are copied via
cp-to-llvm.sh.