Skip to content

[lldb] Remove an unused local variable (NFC) #142882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

Note that CommandArgumentEntry is an alias for:

std::vector

Note that CommandArgumentEntry is an alias for:

  std::vector<CommandArgumentData>
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

Note that CommandArgumentEntry is an alias for:

std::vector<CommandArgumentData>


Full diff: https://github.com/llvm/llvm-project/pull/142882.diff

1 Files Affected:

  • (modified) lldb/source/Commands/CommandObjectBreakpoint.cpp (-1)
diff --git a/lldb/source/Commands/CommandObjectBreakpoint.cpp b/lldb/source/Commands/CommandObjectBreakpoint.cpp
index 494d6c50e94ac..a0c39cf670d46 100644
--- a/lldb/source/Commands/CommandObjectBreakpoint.cpp
+++ b/lldb/source/Commands/CommandObjectBreakpoint.cpp
@@ -1094,7 +1094,6 @@ class CommandObjectBreakpointList : public CommandObjectParsed {
             interpreter, "breakpoint list",
             "List some or all breakpoints at configurable levels of detail.",
             nullptr) {
-    CommandArgumentEntry arg;
     CommandArgumentData bp_id_arg;
 
     // Define the first (and only) variant of this arg.

Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm confused by the choice of reviewers given that this is a file in LLDB.

@kazutakahirata kazutakahirata merged commit 0bcf9af into llvm:main Jun 5, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250604_unused_local_lldb branch June 5, 2025 05:43
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
Note that CommandArgumentEntry is an alias for:

  std::vector<CommandArgumentData>
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
Note that CommandArgumentEntry is an alias for:

  std::vector<CommandArgumentData>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants