Skip to content

[clang-repl] Mark disambiguate-decl-stmt.cpp as UNSUPPORTED on ppc64le and AIX #142923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anutosh491
Copy link
Member

After #142749 went in, I got these set of mails from the buildbot saying

image

saying

The Buildbot has detected a new failure on builder clang-ppc64le-rhel while building clang.

Full details are available at:
https://lab.llvm.org/buildbot/#/builders/145/builds/7528

Worker for this Build: ppc64le-clang-rhel-test
Blamelist:
Anutosh Bhat <[email protected]>,
Jannick Kremer <[email protected]>,
Jie Fu <[email protected]>,
Kazu Hirata <[email protected]>,
Rainer Orth <[email protected]>

BUILD FAILED: failed test (failure)

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Interpreter/disambiguate-decl-stmt.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):

/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/bin/clang -cc1 -internal-isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib/clang/21/include -nostdsysteminc -fsyntax-only -verify -fincremental-extensions -std=c++20 /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp # RUN: at line 1

  • /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/bin/clang -cc1 -internal-isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib/clang/21/include -nostdsysteminc -fsyntax-only -verify -fincremental-extensions -std=c++20 /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp
    error: 'expected-error' diagnostics seen but not expected:
    File /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp Line 113: _Float16 is not supported on this target
    1 error generated.

--


Sincerely,
LLVM Buildbot

This is the file I had changed hence I was responsible here.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-clang

Author: Anutosh Bhat (anutosh491)

Changes

After #142749 went in, I got these set of mails from the buildbot saying

image

saying

The Buildbot has detected a new failure on builder clang-ppc64le-rhel while building clang.

Full details are available at:
https://lab.llvm.org/buildbot/#/builders/145/builds/7528

Worker for this Build: ppc64le-clang-rhel-test
Blamelist:
Anutosh Bhat <[[email protected]](mailto:[email protected])>,
Jannick Kremer <[[email protected]](mailto:[email protected])>,
Jie Fu <[[email protected]](mailto:[email protected])>,
Kazu Hirata <[[email protected]](mailto:[email protected])>,
Rainer Orth <[[email protected]](mailto:[email protected])>

BUILD FAILED: failed test (failure)

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Interpreter/disambiguate-decl-stmt.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):

/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/bin/clang -cc1 -internal-isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib/clang/21/include -nostdsysteminc -fsyntax-only -verify -fincremental-extensions -std=c++20 /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp # RUN: at line 1

  • /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/bin/clang -cc1 -internal-isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib/clang/21/include -nostdsysteminc -fsyntax-only -verify -fincremental-extensions -std=c++20 /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp
    error: 'expected-error' diagnostics seen but not expected:
    File /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/clang/test/Interpreter/disambiguate-decl-stmt.cpp Line 113: _Float16 is not supported on this target
    1 error generated.

--


Sincerely,
LLVM Buildbot

This is the file I had changed hence I was responsible here.


Full diff: https://github.com/llvm/llvm-project/pull/142923.diff

1 Files Affected:

  • (modified) clang/test/Interpreter/disambiguate-decl-stmt.cpp (+1)
diff --git a/clang/test/Interpreter/disambiguate-decl-stmt.cpp b/clang/test/Interpreter/disambiguate-decl-stmt.cpp
index f2a59c510f9a2..3e084275268bd 100644
--- a/clang/test/Interpreter/disambiguate-decl-stmt.cpp
+++ b/clang/test/Interpreter/disambiguate-decl-stmt.cpp
@@ -1,3 +1,4 @@
+// UNSUPPORTED: target=ppc64le{{.*}}, target=aix{{.*}}
 // RUN: %clang_cc1 -fsyntax-only -verify -fincremental-extensions -std=c++20 %s
 // RUN: %clang_cc1 -fsyntax-only -DMS -fms-extensions -verify -fincremental-extensions -std=c++20 %s
 

@anutosh491
Copy link
Member Author

So one way probably to address this would have been how its done here

// RUN: %clang_cc1 -fsyntax-only -verify -triple i686-linux-pc %s
// RUN: %clang_cc1 -fsyntax-only -verify -triple i686-linux-pc -target-feature +sse2 %s -DHAVE
// RUN: %clang_cc1 -fsyntax-only -verify -triple x86_64-linux-pc %s -DHAVE
// RUN: %clang_cc1 -fsyntax-only -verify -triple spir-unknown-unknown %s -DHAVE
// RUN: %clang_cc1 -fsyntax-only -verify -triple armv7a-linux-gnu %s -DHAVE
// RUN: %clang_cc1 -fsyntax-only -verify -triple aarch64-linux-gnu %s -DHAVE
#ifdef HAVE
// expected-no-diagnostics
#endif // HAVE
#ifndef HAVE
// expected-error@+2{{_Float16 is not supported on this target}}
#endif // !HAVE
_Float16 f;

where we can define through a macro as to when we want to run the tests, so in our case I guess something like

// RUN: %clang_cc1 ... %s
// RUN: %clang_cc1 ... -triple x86_64-linux-gnu -DHAVE %s

or we can mark these platforms as unsupported as done through the PR.

@anutosh491 anutosh491 marked this pull request as draft June 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants