Skip to content

[TableGen] Remove last remnant of CompositeIndices #142960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

jayfoad
Copy link
Contributor

@jayfoad jayfoad commented Jun 5, 2025

The rest of the support was removed in 2012 by:
5995936 "Remove support for 'CompositeIndices' and sub-register cycles."

The rest of the support was removed in 2012 by:
5995936 "Remove support for 'CompositeIndices' and sub-register cycles."
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-tablegen

Author: Jay Foad (jayfoad)

Changes

The rest of the support was removed in 2012 by:
5995936 "Remove support for 'CompositeIndices' and sub-register cycles."


Full diff: https://github.com/llvm/llvm-project/pull/142960.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/Common/CodeGenRegisters.cpp (+1-1)
diff --git a/llvm/utils/TableGen/Common/CodeGenRegisters.cpp b/llvm/utils/TableGen/Common/CodeGenRegisters.cpp
index 6b0b1ccba80fb..42142a95fb91c 100644
--- a/llvm/utils/TableGen/Common/CodeGenRegisters.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenRegisters.cpp
@@ -703,7 +703,7 @@ struct TupleExpander : SetTheory::Expander {
           RV.setValue(BitInit::get(RK, true));
 
         // Copy fields from the RegisterTuples def.
-        if (Field == "SubRegIndices" || Field == "CompositeIndices") {
+        if (Field == "SubRegIndices") {
           NewReg->addValue(*Def->getValue(Field));
           continue;
         }

@nvjle
Copy link
Contributor

nvjle commented Jun 5, 2025

LGTM.

@jayfoad jayfoad merged commit f871466 into llvm:main Jun 5, 2025
13 checks passed
@jayfoad jayfoad deleted the remove-compositeindices branch June 5, 2025 16:02
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
The rest of the support was removed in 2012 by:
5995936 "Remove support for 'CompositeIndices' and sub-register cycles."
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
The rest of the support was removed in 2012 by:
5995936 "Remove support for 'CompositeIndices' and sub-register cycles."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants