Skip to content

[LLDB][NFC]Add missing getKind/classof methods for ClientInfo #142984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

oontvoo
Copy link
Member

@oontvoo oontvoo commented Jun 5, 2025

No description provided.

@oontvoo oontvoo requested a review from labath June 5, 2025 14:56
@oontvoo oontvoo requested a review from JDevlieghere as a code owner June 5, 2025 14:56
@llvmbot llvmbot added the lldb label Jun 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-lldb

Author: Vy Nguyen (oontvoo)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/142984.diff

1 Files Affected:

  • (modified) lldb/include/lldb/Core/Telemetry.h (+11)
diff --git a/lldb/include/lldb/Core/Telemetry.h b/lldb/include/lldb/Core/Telemetry.h
index 5be68de6fcd7f..1db69723b4706 100644
--- a/lldb/include/lldb/Core/Telemetry.h
+++ b/lldb/include/lldb/Core/Telemetry.h
@@ -102,6 +102,17 @@ struct ClientInfo : public LLDBBaseTelemetryInfo {
   std::string client_data;
   std::optional<std::string> error_msg;
 
+  // For dyn_cast, isa, etc operations.
+  llvm::telemetry::KindType getKind() const override {
+    return LLDBEntryKind::ClientInfo;
+  }
+
+  static bool classof(const llvm::telemetry::TelemetryInfo *t) {
+    // Subclasses of this is also acceptable.
+    return (t->getKind() & LLDBEntryKind::ClientInfo) ==
+           LLDBEntryKind::ClientInfo;
+  }
+
   void serialize(llvm::telemetry::Serializer &serializer) const override;
 };
 

@oontvoo oontvoo merged commit eb6577d into llvm:main Jun 5, 2025
9 of 11 checks passed
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants