[bazel] Fix LLVM plugin tests under Analysis. #142999
Conversation
Those tests were broken on bazel as a side effect of 8830e38. This commit is tested with this command on Linux: bazelisk test \ @llvm-project//llvm/unittests:analysis_tests \ @llvm-project//llvm/unittests:plugin_inline_advisor_analysis_test \ @llvm-project//llvm/unittests:plugin_inline_order_analysis_test
Thanks for the review. Since this only affects bazel and the tests were broken before, I feel this commit should be safe to submit. It is currently 2AM in Japan so I don't think @chapuni will be able to respond soon. Let me submit this commit now to avoid other issues being hidden under it. |
| # These tests dynamically load Plugins which both pull in | ||
| # llvm/lib/Analysis/ProfileSummaryInfo.cpp, which registers flags; | ||
| # if built into the same cc_test target, those flags will be | ||
| # registered twice and cause runtime failures. | ||
| "Analysis/PluginInlineAdvisorAnalysisTest.cpp", | ||
| "Analysis/PluginInlineOrderAnalysisTest.cpp", |
There was a problem hiding this comment.
Let me investigate further later,
| deps = [ | ||
| "//llvm:Analysis", | ||
| "//llvm:Core", | ||
| "//llvm:Passes", | ||
| "//llvm:Support", | ||
| ], |
There was a problem hiding this comment.
They should be handled as "interface libs". Plugins shouldn't link them.
There was a problem hiding this comment.
Plugins shouldn't link them.
Actually, I just realized this is why I had to use separate targets for the plugin tests; if they are not linked into the plugins, there would be no duplicate flag registrations.
The right way to do this, is probably to introduce header-only versions of these four dependencies, and use them to build the plugin. But since these are just tests, I guess we are somewhat fine here...?
Those tests were broken on bazel as a side effect of 8830e38. This commit is tested with this command on Linux: bazelisk test \ @llvm-project//llvm/unittests:analysis_tests \ @llvm-project//llvm/unittests:plugin_inline_advisor_analysis_test \ @llvm-project//llvm/unittests:plugin_inline_order_analysis_test
Those tests were broken on bazel as a side effect of 8830e38. This commit is tested with this command on Linux: bazelisk test \ @llvm-project//llvm/unittests:analysis_tests \ @llvm-project//llvm/unittests:plugin_inline_advisor_analysis_test \ @llvm-project//llvm/unittests:plugin_inline_order_analysis_test
Those tests were broken on bazel as a side effect of 8830e38.
This commit is tested with this command on Linux: