Skip to content

[Offload] Fix APU detection for MI300 testing #143026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

jhuber6
Copy link
Contributor

@jhuber6 jhuber6 commented Jun 5, 2025

Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.

Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.
@llvmbot
Copy link
Member

llvmbot commented Jun 5, 2025

@llvm/pr-subscribers-offload

Author: Joseph Huber (jhuber6)

Changes

Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.


Full diff: https://github.com/llvm/llvm-project/pull/143026.diff

1 Files Affected:

  • (modified) offload/test/lit.cfg (+1-2)
diff --git a/offload/test/lit.cfg b/offload/test/lit.cfg
index 0725b56f0f05d..df57be293138c 100644
--- a/offload/test/lit.cfg
+++ b/offload/test/lit.cfg
@@ -36,8 +36,7 @@ if 'HSA_ENABLE_SDMA' in os.environ:
 
 # Architectures like gfx942 may or may not be APUs so an additional environment
 # variable is required as some tests can be APU specific.
-if 'IS_APU' in os.environ:
-    config.environment['IS_APU'] = os.environ['IS_APU']
+config.environment['IS_APU'] = os.environ.get('IS_APU', '0')
 
 # set default environment variables for test
 if 'CHECK_OPENMP_ENV' in os.environ:

@jhuber6 jhuber6 merged commit 0519453 into llvm:main Jun 5, 2025
7 of 9 checks passed
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
Summary:
We have this check when the target is MI300 but it fails if this
environment variable isn't set. Set a default value of '0' if not
present so that will be converted to bool false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants