[lldb] Fix linux x64 test #143048
Merged
[lldb] Fix linux x64 test #143048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Prabhu Rajasekaran (Prabhuk) Changes
Full diff: https://github.com/llvm/llvm-project/pull/143048.diff 1 Files Affected:
diff --git a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py b/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
index b71f3421f9834..71f805e7f296b 100644
--- a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
+++ b/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
@@ -58,19 +58,19 @@ def test_stop_hooks_scripted_no_entry(self):
def test_stop_hooks_scripted_right_func(self):
"""Test that a scripted stop hook fires when there is a function match"""
- self.stop_hooks_scripted(5, "-n step_out_of_me")
+ self.stop_hooks_scripted(5, "-I 0 -n step_out_of_me")
def test_stop_hooks_scripted_wrong_func(self):
"""Test that a scripted stop hook doesn't fire when the function does not match"""
- self.stop_hooks_scripted(0, "-n main")
+ self.stop_hooks_scripted(0, "-I 0 -n main")
def test_stop_hooks_scripted_right_lines(self):
"""Test that a scripted stop hook fires when there is a function match"""
- self.stop_hooks_scripted(5, "-f main.c -l 1 -e %d" % (self.main_start_line))
+ self.stop_hooks_scripted(5, "-I 0 -f main.c -l 1 -e %d" % (self.main_start_line))
def test_stop_hooks_scripted_wrong_lines(self):
"""Test that a scripted stop hook doesn't fire when the function does not match"""
- self.stop_hooks_scripted(0, "-f main.c -l %d -e 100" % (self.main_start_line))
+ self.stop_hooks_scripted(0, "-I 0 -f main.c -l %d -e 100" % (self.main_start_line))
def test_stop_hooks_scripted_auto_continue(self):
"""Test that the --auto-continue flag works"""
@@ -89,9 +89,9 @@ def do_test_auto_continue(self, return_true):
result = lldb.SBCommandReturnObject()
if return_true:
- command = "target stop-hook add -P stop_hook.stop_handler -k increment -v 5 -k return_false -v 1 -n step_out_of_me"
+ command = "target stop-hook add -I 0 -P stop_hook.stop_handler -k increment -v 5 -k return_false -v 1 -n step_out_of_me"
else:
- command = "target stop-hook add -G 1 -P stop_hook.stop_handler -k increment -v 5 -n step_out_of_me"
+ command = "target stop-hook add -I 0 -G 1 -P stop_hook.stop_handler -k increment -v 5 -n step_out_of_me"
self.interp.HandleCommand(command, result)
self.assertTrue(result.Succeeded(), "Set the target stop hook")
|
|
✅ With the latest revision this PR passed the Python code formatter. |
jimingham
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
I still don't understand the failures that triggered this patch - stopping at the entry point somehow is at a place where both the function name filter for main and step_into_me pass - even though that should be the same stop-point for both checks. That seems quite odd.
But this test was not intending to test entry point behavior, so it's fine to exclude this for the purposes of this test.
You still have to fix the Python formatting but then this should be fine.
Test was failing for cases where -I 0 was not passed to stop-hook add calls.
Can we file a bug for this? If there are patches that you'd like me to try in our environment to address the bug I'll be happy to do so. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/23971 Here is the relevant piece of the build log for the reference |
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
`TestStopHookScripted.py` Was failing for cases where -I 0 was not passed to stop-hook add calls.
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
`TestStopHookScripted.py` Was failing for cases where -I 0 was not passed to stop-hook add calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStopHookScripted.pyWas failing for cases where -I 0 was not passed to stop-hook add calls.