Skip to content

[LLVM][Tests] remove %exeext from lli-child-target parameter. #143077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

jeremyd2019
Copy link
Contributor

Its presence seems to actively hinder the ToolSubst mechanism that was supposed to fill in the path to the tool, which prevented these tests from working on Cygwin.

Its presence seems to actively hinder the ToolSubst mechanism that was
supposed to fill in the path to the tool, which prevented these tests
from working on Cygwin.
@jeremyd2019
Copy link
Contributor Author

jeremyd2019 commented Jun 6, 2025

cc @mstorsjo

Given these tests are already expected to fail on Windows otherwise, this was probably just an oversight. Unless there's some other platform that uses %exeext that this might break.

This brings llvm test failures on Cygwin from 50 down to 39.

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I can confirm that on a mingw target, this previously passed -mcjit-remote-process=lli-child-target.exe, while it now passes -mcjit-remote-process=c:\full\path\to\build\bin\lli-child-target.exe. The tests still fail expectedly like before.

@mstorsjo mstorsjo merged commit d34b392 into llvm:main Jun 8, 2025
8 checks passed
@jeremyd2019 jeremyd2019 deleted the llvm-lli-child-target-no-exeext branch June 8, 2025 17:52
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jun 8, 2025

LLVM Buildbot has detected a new failure on builder publish-sphinx-docs running on as-worker-4 while building llvm at step 12 "Publish docs-openmp-html".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/13078

Here is the relevant piece of the build log for the reference
Step 12 (Publish docs-openmp-html) failure: 'rsync -vrl ...' (failure)
kex_exchange_identification: Connection closed by remote host
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(235) [sender=3.1.3]

rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
…43077)

Its presence seems to actively hinder the ToolSubst mechanism that was
supposed to fill in the path to the tool, which prevented these tests
from working on Cygwin.
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
…43077)

Its presence seems to actively hinder the ToolSubst mechanism that was
supposed to fill in the path to the tool, which prevented these tests
from working on Cygwin.
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
…43077)

Its presence seems to actively hinder the ToolSubst mechanism that was
supposed to fill in the path to the tool, which prevented these tests
from working on Cygwin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants