[LLD][Cygwin] Add libcygwin to exclude from auto-export library list #143118
Conversation
|
@llvm/pr-subscribers-platform-windows @llvm/pr-subscribers-lld Author: Tomohiro Kashiwada (kikairoya) ChangesLinking for Cygwin target always needs -lcygwin but should not auto-exported from it, same as -lmingw for MinGW target. Full diff: https://github.com/llvm/llvm-project/pull/143118.diff 1 Files Affected:
diff --git a/lld/COFF/MinGW.cpp b/lld/COFF/MinGW.cpp
index ca9ae403f181b..4f31ad36f025d 100644
--- a/lld/COFF/MinGW.cpp
+++ b/lld/COFF/MinGW.cpp
@@ -46,6 +46,7 @@ AutoExporter::AutoExporter(
"libclang_rt.profile-arm",
"libclang_rt.profile-i386",
"libclang_rt.profile-x86_64",
+ "libcygwin",
"libc++",
"libc++abi",
"libflang_rt.runtime",
|
|
Maybe add libmsys-2.0 at the same time? |
…rt library list Linking for Cygwin target always needs -lcygwin (and, -lmsys-2.0 instead for MSYS2 target) but should not auto-export from them, same as -lmingw32 for MinGW target.
There was a problem hiding this comment.
LGTM
When updating the intended commit message, it's recommended that you update the PR subject/description accordingly as well. When merging (with "squash and merge" as is the only alternative in llvm-project), the default commit message is based on the PR subject/description, not the individual commit messages. In this case I can take care to update it manually when merging though.
|
Sorry for the extra work, and I really appreciate your help. |
…rt library list (llvm#143118) Linking for Cygwin target always needs -lcygwin (and, -lmsys-2.0 instead for MSYS2 target) but should not auto-export from them, same as -lmingw32 for MinGW target.
…rt library list (llvm#143118) Linking for Cygwin target always needs -lcygwin (and, -lmsys-2.0 instead for MSYS2 target) but should not auto-export from them, same as -lmingw32 for MinGW target.
…rt library list (llvm#143118) Linking for Cygwin target always needs -lcygwin (and, -lmsys-2.0 instead for MSYS2 target) but should not auto-export from them, same as -lmingw32 for MinGW target.
Linking for Cygwin target always needs -lcygwin but should not auto-exported from it, same as -lmingw for MinGW target.