-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[flang] Fix missing includes in lib/Lower/Support/Utils.cpp #143196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the build failure due to missing includes introduced in f8dcb05.
@llvm/pr-subscribers-flang-fir-hlfir Author: Michał Górny (mgorny) ChangesFixes the build failure due to missing includes introduced in f8dcb05. Full diff: https://github.com/llvm/llvm-project/pull/143196.diff 1 Files Affected:
diff --git a/flang/lib/Lower/Support/Utils.cpp b/flang/lib/Lower/Support/Utils.cpp
index 674f9911b1276..63b5e89cb5b9a 100644
--- a/flang/lib/Lower/Support/Utils.cpp
+++ b/flang/lib/Lower/Support/Utils.cpp
@@ -13,9 +13,15 @@
#include "flang/Lower/Support/Utils.h"
#include "flang/Common/indirection.h"
+#include "flang/Lower/ConvertVariable.h"
+#include "flang/Lower/AbstractConverter.h"
#include "flang/Lower/IterationSpace.h"
#include "flang/Lower/Support/PrivateReductionUtils.h"
+#include "flang/Optimizer/Builder/HLFIRTools.h"
+#include "flang/Optimizer/Builder/Todo.h"
+#include "flang/Optimizer/HLFIR/HLFIRDialect.h"
#include "flang/Semantics/tools.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
#include <cstdint>
#include <optional>
#include <type_traits>
|
Without this, I'm seeing lots of errors (I guess pch hides them):
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
kparzysz
approved these changes
Jun 7, 2025
Thanks! |
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
) Fixes the build failure due to missing includes introduced in f8dcb05.
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
) Fixes the build failure due to missing includes introduced in f8dcb05.
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
) Fixes the build failure due to missing includes introduced in f8dcb05.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build failure due to missing includes introduced in f8dcb05.