Skip to content

[llvm-remarkutil] bitstream2yaml: Keep output file #143220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

tobias-stadler
Copy link
Contributor

@tobias-stadler tobias-stadler commented Jun 7, 2025

Keep the output file on successful exit, otherwise llvm-remarkutil bitstream2yaml -o filename.yaml ... does not produce any output, because the output file is deleted when the tool exits.

Keep the output file on successful exit.
@tobias-stadler tobias-stadler requested review from fhahn and jroelofs June 7, 2025 00:50
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but could you expand the PR description with the motivation for keeping the output file.

@tobias-stadler tobias-stadler requested a review from fhahn June 11, 2025 12:26
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tobias-stadler tobias-stadler merged commit b6a56b8 into llvm:main Jun 12, 2025
8 checks passed
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
Keep the output file on successful exit, otherwise `llvm-remarkutil
bitstream2yaml -o filename.yaml ...` does not produce any output,
because the output file is deleted when the tool exits.
akuhlens pushed a commit to akuhlens/llvm-project that referenced this pull request Jun 24, 2025
Keep the output file on successful exit, otherwise `llvm-remarkutil
bitstream2yaml -o filename.yaml ...` does not produce any output,
because the output file is deleted when the tool exits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants