[Cygwin] Define LLVM_ABI for Cygwin #143222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
592243c should be also applied to LLVM_ABI.
|
@llvm/pr-subscribers-llvm-support Author: Tomohiro Kashiwada (kikairoya) Changes592243c should be also applied to LLVM_ABI. Full diff: https://github.com/llvm/llvm-project/pull/143222.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index b4382057654ba..904ab88a5a51f 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -209,7 +209,7 @@
#define LLVM_ABI_FRIEND LLVM_ABI
#define LLVM_ABI_EXPORT __declspec(dllexport)
#elif defined(__ELF__) || defined(__MINGW32__) || defined(_AIX) || \
- defined(__MVS__)
+ defined(__MVS__) || defined(__CYGWIN__)
#define LLVM_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
#define LLVM_ABI_FRIEND
#define LLVM_TEMPLATE_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
|
jeremyd2019
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
LGTM, probably just an oversight when @mati865 was splitting up his patches
|
Indeed, it was present in #134458 Gonna have to check what else is missing. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/207/builds/2550 Here is the relevant piece of the build log for the reference |
kikairoya
added a commit
to kikairoya/llvm-project
that referenced
this pull request
Jun 14, 2025
Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change. This reverts commit 60d0004.
Reconciling patches, it seems you had only done the clang commit and not gotten to the llvm commit |
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
592243c should be also applied to LLVM_ABI.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
592243c should be also applied to LLVM_ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
592243c should be also applied to LLVM_ABI.