Skip to content

[Clang][NFC] Adopt simpified getTrailingObjects in CIRGenFunctionInfo #143253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Jun 7, 2025

No description provided.

@jurahul jurahul changed the title [NFC][Clang][CIR] Adopt simpified getTrailingObjects in CIRGenFunct… [NFC][Clang] Adopt simpified getTrailingObjects in CIRGenFunctionInfo Jun 7, 2025
@jurahul jurahul marked this pull request as ready for review June 7, 2025 13:33
@jurahul jurahul requested review from erichkeane and removed request for bcardosolopes and lanza June 7, 2025 13:33
@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Jun 7, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 7, 2025

@llvm/pr-subscribers-clang

Author: Rahul Joshi (jurahul)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/143253.diff

1 Files Affected:

  • (modified) clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h (+2-4)
diff --git a/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h b/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
index 9886574fd463b..4f5754cb43986 100644
--- a/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
+++ b/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
@@ -76,10 +76,8 @@ class CIRGenFunctionInfo final
 
   unsigned numArgs;
 
-  CanQualType *getArgTypes() { return getTrailingObjects<CanQualType>(); }
-  const CanQualType *getArgTypes() const {
-    return getTrailingObjects<CanQualType>();
-  }
+  CanQualType *getArgTypes() { return getTrailingObjects(); }
+  const CanQualType *getArgTypes() const { return getTrailingObjects(); }
 
   CIRGenFunctionInfo() : required(RequiredArgs::All) {}
 

@llvmbot
Copy link
Member

llvmbot commented Jun 7, 2025

@llvm/pr-subscribers-clangir

Author: Rahul Joshi (jurahul)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/143253.diff

1 Files Affected:

  • (modified) clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h (+2-4)
diff --git a/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h b/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
index 9886574fd463b..4f5754cb43986 100644
--- a/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
+++ b/clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h
@@ -76,10 +76,8 @@ class CIRGenFunctionInfo final
 
   unsigned numArgs;
 
-  CanQualType *getArgTypes() { return getTrailingObjects<CanQualType>(); }
-  const CanQualType *getArgTypes() const {
-    return getTrailingObjects<CanQualType>();
-  }
+  CanQualType *getArgTypes() { return getTrailingObjects(); }
+  const CanQualType *getArgTypes() const { return getTrailingObjects(); }
 
   CIRGenFunctionInfo() : required(RequiredArgs::All) {}
 

@jurahul jurahul requested a review from andykaylor June 7, 2025 17:32
@bcardosolopes bcardosolopes changed the title [NFC][Clang] Adopt simpified getTrailingObjects in CIRGenFunctionInfo [Clang][NFC] Adopt simpified getTrailingObjects in CIRGenFunctionInfo Jun 9, 2025
@bcardosolopes bcardosolopes merged commit e4060d3 into llvm:main Jun 9, 2025
12 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jun 9, 2025

LLVM Buildbot has detected a new failure on builder lldb-aarch64-ubuntu running on linaro-lldb-aarch64-ubuntu while building clang at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/19065

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: ValueObject/./LLDBValueObjectTests/7/12 (2235 of 2245)
PASS: lldb-unit :: ValueObject/./LLDBValueObjectTests/8/12 (2236 of 2245)
PASS: lldb-unit :: ValueObject/./LLDBValueObjectTests/9/12 (2237 of 2245)
PASS: lldb-unit :: tools/lldb-server/tests/./LLDBServerTests/0/2 (2238 of 2245)
PASS: lldb-unit :: tools/lldb-server/tests/./LLDBServerTests/1/2 (2239 of 2245)
PASS: lldb-unit :: Utility/./UtilityTests/4/9 (2240 of 2245)
PASS: lldb-unit :: Host/./HostTests/10/13 (2241 of 2245)
PASS: lldb-unit :: Target/./TargetTests/11/14 (2242 of 2245)
PASS: lldb-unit :: Host/./HostTests/2/13 (2243 of 2245)
PASS: lldb-unit :: Process/gdb-remote/./ProcessGdbRemoteTests/8/9 (2244 of 2245)
command timed out: 2400 seconds without output running [b'ninja', b'check-lldb'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=2702.819384

rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants