Skip to content

[mlir][SparseTensor] Re-enable tests on AArch64 #143387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

banach-space
Copy link
Contributor

@banach-space banach-space commented Jun 9, 2025

These tests were disabled in https://reviews.llvm.org/D136273, due to:

That issue has now been resolved, so we should be able to re-enable
these tests.

NOTE: Currently blocked by #143386

These tests were disabled in https://reviews.llvm.org/D136273, due to:
* llvm#58465

That issue has now been resolved, so we should be able to re-enable
these tests.
@llvmbot
Copy link
Member

llvmbot commented Jun 9, 2025

@llvm/pr-subscribers-mlir

Author: Andrzej Warzyński (banach-space)

Changes

These tests were disabled in https://reviews.llvm.org/D136273, due to:

That issue has now been resolved, so we should be able to re-enable
these tests.


Full diff: https://github.com/llvm/llvm-project/pull/143387.diff

2 Files Affected:

  • (modified) mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir (-2)
  • (modified) mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir (-2)
diff --git a/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir b/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
index bb7dcd2f35e33..40a0351a83ee9 100644
--- a/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
+++ b/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
@@ -28,8 +28,6 @@
 // REDEFINE: %{sparsifier_opts} = enable-runtime-library=false vl=2 reassociate-fp-reductions=true enable-index-optimizations=true
 // RUN: %{compile} | %{run} | FileCheck %s
 
-// UNSUPPORTED: target=aarch64{{.*}}
-
 #SparseVector = #sparse_tensor.encoding<{map = (d0) -> (d0 : compressed)}>
 #DenseVector = #sparse_tensor.encoding<{map = (d0) -> (d0 : dense)}>
 
diff --git a/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir b/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
index a0711d5b577a3..440c1b63c8c28 100644
--- a/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
+++ b/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
@@ -30,8 +30,6 @@
 // Do the same run, but now with  VLA vectorization.
 // RUN: %if mlir_arm_sve_tests %{ %{compile_sve} | %{run_sve} | FileCheck %s %}
 
-// UNSUPPORTED: target=aarch64{{.*}}, mlir_arm_emulator
-
 !Filename = !llvm.ptr
 
 #SparseMatrix = #sparse_tensor.encoding<{

@llvmbot
Copy link
Member

llvmbot commented Jun 9, 2025

@llvm/pr-subscribers-mlir-sparse

Author: Andrzej Warzyński (banach-space)

Changes

These tests were disabled in https://reviews.llvm.org/D136273, due to:

That issue has now been resolved, so we should be able to re-enable
these tests.


Full diff: https://github.com/llvm/llvm-project/pull/143387.diff

2 Files Affected:

  • (modified) mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir (-2)
  • (modified) mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir (-2)
diff --git a/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir b/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
index bb7dcd2f35e33..40a0351a83ee9 100644
--- a/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
+++ b/mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir
@@ -28,8 +28,6 @@
 // REDEFINE: %{sparsifier_opts} = enable-runtime-library=false vl=2 reassociate-fp-reductions=true enable-index-optimizations=true
 // RUN: %{compile} | %{run} | FileCheck %s
 
-// UNSUPPORTED: target=aarch64{{.*}}
-
 #SparseVector = #sparse_tensor.encoding<{map = (d0) -> (d0 : compressed)}>
 #DenseVector = #sparse_tensor.encoding<{map = (d0) -> (d0 : dense)}>
 
diff --git a/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir b/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
index a0711d5b577a3..440c1b63c8c28 100644
--- a/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
+++ b/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir
@@ -30,8 +30,6 @@
 // Do the same run, but now with  VLA vectorization.
 // RUN: %if mlir_arm_sve_tests %{ %{compile_sve} | %{run_sve} | FileCheck %s %}
 
-// UNSUPPORTED: target=aarch64{{.*}}, mlir_arm_emulator
-
 !Filename = !llvm.ptr
 
 #SparseMatrix = #sparse_tensor.encoding<{

@banach-space banach-space merged commit 8db272f into llvm:main Jun 20, 2025
10 checks passed
@banach-space banach-space deleted the andrzej/re_enable_e2e_mlir_tests branch June 20, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:sparse Sparse compiler in MLIR mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants