Skip to content

[NFC][DebugInfo] Make MDNodeKeyImpl<DILocation>::Column 16 bits #143399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

[NFC][DebugInfo] Make MDNodeKeyImpl<DILocation>::Column 16 bits #143399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb4a8b6
[NFC][DebugInfo] Make MDNodeKeyImpl<DILocation>::Column 16 bits
OCHyams Jun 9, 2025
865e758
update ctor
OCHyams Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/IR/LLVMContextImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ template <> struct MDNodeKeyImpl<MDTuple> : MDNodeOpsKey {
/// DenseMapInfo for DILocation.
template <> struct MDNodeKeyImpl<DILocation> {
unsigned Line;
unsigned Column;
uint16_t Column;
Metadata *Scope;
Metadata *InlinedAt;
bool ImplicitCode;
Expand All @@ -320,7 +320,7 @@ template <> struct MDNodeKeyImpl<DILocation> {
uint64_t AtomRank : 3;
#endif

MDNodeKeyImpl(unsigned Line, unsigned Column, Metadata *Scope,
MDNodeKeyImpl(unsigned Line, uint16_t Column, Metadata *Scope,
Metadata *InlinedAt, bool ImplicitCode, uint64_t AtomGroup,
uint8_t AtomRank)
: Line(Line), Column(Column), Scope(Scope), InlinedAt(InlinedAt),
Expand Down