[flang][common] return ENUM_CLASS names definition to original state #143553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any suggestion on how to test that the PR actually fixes the broken build bots? |
klausler
approved these changes
Jun 10, 2025
Only one way to be sure. |
eugeneepshteyn
approved these changes
Jun 10, 2025
|
Hello! May I ask if we are going to merge this fix any time soon? |
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
…lvm#143553) This PR simply reverts a few lines in bf60aa1 to their state in bcba39a so that they are constant for some of the build tests that require it. This should fix the breakage caused by llvm#142022.
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…lvm#143553) This PR simply reverts a few lines in bf60aa1 to their state in bcba39a so that they are constant for some of the build tests that require it. This should fix the breakage caused by llvm#142022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply reverts a few lines in bf60aa1 to their state in bcba39a so that they are constant for some of the build tests that require it. This should fix the breakage caused by #142022.