[Clang][ByteCode][NFC] Move APInt into pushInteger since it is being passed by value #143578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passed by value Static analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) ChangesStatic analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt. Full diff: https://github.com/llvm/llvm-project/pull/143578.diff 1 Files Affected:
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index b678f229d50bb..5fc5034569597 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -1321,7 +1321,7 @@ static bool interp__builtin_ia32_pdep(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(I, Val[P++]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
@@ -1344,7 +1344,7 @@ static bool interp__builtin_ia32_pext(InterpState &S, CodePtr OpPC,
if (Mask[I])
Result.setBitVal(P++, Val[I]);
}
- pushInteger(S, Result, Call->getType());
+ pushInteger(S, std::move(Result), Call->getType());
return true;
}
|
tbaederr
approved these changes
Jun 11, 2025
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…passed by value (llvm#143578) Static analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
…passed by value (llvm#143578) Static analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis flagged that we could move APInt instead of copy, indeed it has a move constructor and so we should move into values for APInt.