-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Disable prctl test when building for arm or riscv. #143627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-libc Author: Amy Huang (amykhuang) ChangesI'm setting up a buildbot for arm32 using qemu and qemu doesn't support PR_GET_THP_DISABLE. Also disable for riscv because we may do the same for riscv buildbots. Full diff: https://github.com/llvm/llvm-project/pull/143627.diff 1 Files Affected:
diff --git a/libc/test/src/sys/prctl/linux/CMakeLists.txt b/libc/test/src/sys/prctl/linux/CMakeLists.txt
index b06e1c8087008..d02900e1857a0 100644
--- a/libc/test/src/sys/prctl/linux/CMakeLists.txt
+++ b/libc/test/src/sys/prctl/linux/CMakeLists.txt
@@ -1,5 +1,10 @@
add_custom_target(libc_sys_prctl_unittests)
+# Temporarily disable this test while setting up arm and riscv buildbots
+# using qemu, since PR_GET_THP_DISABLE is not supported on qemu.
+if (NOT (LIBC_TARGET_ARCHITECTURE_IS_ARM OR
+ LIBC_TARGET_ARCHITECTURE_IS_RISCV32 OR
+ LIBC_TARGET_ARCHITECTURE_IS_RISCV64))
add_libc_unittest(
prctl_test
SUITE
@@ -13,3 +18,4 @@ add_libc_unittest(
libc.test.UnitTest.ErrnoCheckingTest
libc.test.UnitTest.ErrnoSetterMatcher
)
+endif()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a comment in the test itself, it may be useful to change the test to not use PR_GET_THP_DISABLE
if that's the only value that qemu doesn't support.
Added comment; also linking here to which ones QEMU doesn't support: https://gitlab.com/qemu-project/qemu/-/blob/master/linux-user/syscall.c?ref_type=heads#L6519. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm setting up a buildbot for arm32 using qemu and qemu doesn't support PR_GET_THP_DISABLE. Disable the test for now while we figure out what to do about that. Also disable for riscv because we may do the same for riscv buildbots.
I'm setting up a buildbot for arm32 using qemu and qemu doesn't support PR_GET_THP_DISABLE. Disable the test for now while we figure out what to do about that. Also disable for riscv because we may do the same for riscv buildbots.
I'm setting up a buildbot for arm32 using qemu and qemu doesn't support PR_GET_THP_DISABLE. Disable the test for now while we figure out what to do about that. Also disable for riscv because we may do the same for riscv buildbots.
I'm setting up a buildbot for arm32 using qemu and qemu doesn't support PR_GET_THP_DISABLE.
Disable the test for now while we figure out what to do about that.
Also disable for riscv because we may do the same for riscv buildbots.