[llvm][utils] Add synthetic provider for llvm::DenseSet #143631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
commented
Jun 10, 2025
Comment on lines
-375
to
+382
| key = buckets.GetValueForExpressionPath(f"[{index}].first") | ||
| bucket = buckets.GetValueForExpressionPath(f"[{index}]") | ||
| key = bucket.GetChildAtIndex(0) |
There was a problem hiding this comment.
This change is because the entries of a DenseSet are DenseSetPair, which is not actually a pair. There's only one child, and its name is key. The original code works for DenseMapPair, which has two children, first and second. Using GetChildAtIndex(0) will retrieve first for maps, and key for sets.
Michael137
approved these changes
Jun 11, 2025
kastiglione
deleted the
llvm-utils-Add-synthetic-provider-for-llvm-DenseSet
branch
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
Add a synthetic child provider for `DenseSet`, which is a wrapper around `DenseMap`. This provider leverages the existing `DenseMap` provider, reshaping its dictionary structured children into a set.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
Add a synthetic child provider for `DenseSet`, which is a wrapper around `DenseMap`. This provider leverages the existing `DenseMap` provider, reshaping its dictionary structured children into a set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a synthetic child provider for
DenseSet, which is a wrapper aroundDenseMap. This provider leverages the existingDenseMapprovider, reshaping its dictionary structured children into a set.