ARM: Remove fake entries for divrem libcalls #143832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
requested review from
aemerson,
DanielKristofKiss,
dpaoliello,
efriedma-quic,
greened and
sdesmalen-arm
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-arm Author: Matt Arsenault (arsenm) ChangesThis was defining aliases of the i32 divrem functions for the i8 Full diff: https://github.com/llvm/llvm-project/pull/143832.diff 1 Files Affected:
diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index 331b319511aed..d84c56f0af5c6 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -41,13 +41,8 @@ static void setARMLibcallNames(RuntimeLibcallsInfo &Info, const Triple &TT) {
const char *const Name;
const CallingConv::ID CC;
} LibraryCalls[] = {
- {RTLIB::SDIVREM_I8, "__rt_sdiv", CallingConv::ARM_AAPCS},
- {RTLIB::SDIVREM_I16, "__rt_sdiv", CallingConv::ARM_AAPCS},
{RTLIB::SDIVREM_I32, "__rt_sdiv", CallingConv::ARM_AAPCS},
{RTLIB::SDIVREM_I64, "__rt_sdiv64", CallingConv::ARM_AAPCS},
-
- {RTLIB::UDIVREM_I8, "__rt_udiv", CallingConv::ARM_AAPCS},
- {RTLIB::UDIVREM_I16, "__rt_udiv", CallingConv::ARM_AAPCS},
{RTLIB::UDIVREM_I32, "__rt_udiv", CallingConv::ARM_AAPCS},
{RTLIB::UDIVREM_I64, "__rt_udiv64", CallingConv::ARM_AAPCS},
};
@@ -62,13 +57,8 @@ static void setARMLibcallNames(RuntimeLibcallsInfo &Info, const Triple &TT) {
const char *const Name;
const CallingConv::ID CC;
} LibraryCalls[] = {
- {RTLIB::SDIVREM_I8, "__aeabi_idivmod", CallingConv::ARM_AAPCS},
- {RTLIB::SDIVREM_I16, "__aeabi_idivmod", CallingConv::ARM_AAPCS},
{RTLIB::SDIVREM_I32, "__aeabi_idivmod", CallingConv::ARM_AAPCS},
{RTLIB::SDIVREM_I64, "__aeabi_ldivmod", CallingConv::ARM_AAPCS},
-
- {RTLIB::UDIVREM_I8, "__aeabi_uidivmod", CallingConv::ARM_AAPCS},
- {RTLIB::UDIVREM_I16, "__aeabi_uidivmod", CallingConv::ARM_AAPCS},
{RTLIB::UDIVREM_I32, "__aeabi_uidivmod", CallingConv::ARM_AAPCS},
{RTLIB::UDIVREM_I64, "__aeabi_uldivmod", CallingConv::ARM_AAPCS},
};
|
sdesmalen-arm
approved these changes
Jun 12, 2025
arsenm
force-pushed
the
users/arsenm/arm/move-more-runtime-libcalls-runtime-libcall-info
branch
3 times, most recently
from
1a68c13 to
50b8219
Compare
Base automatically changed from
users/arsenm/arm/move-more-runtime-libcalls-runtime-libcall-info
to
main
June 12, 2025 08:35
This was defining aliases of the i32 divrem functions for the i8 and i16 cases. This is unnecessary and was unused. The divrem candidate cases wouldn't have formed with illegal types in the first place, so codegen wouldn't even query these.
arsenm
force-pushed
the
users/arsenm/arm/remove-fake-divrem-libcall-entries
branch
from
47f1862 to
4b01a03
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/30580 Here is the relevant piece of the build log for the reference |
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
This was defining aliases of the i32 divrem functions for the i8 and i16 cases. This is unnecessary and was unused. The divrem candidate cases wouldn't have formed with illegal types in the first place, so codegen wouldn't even query these.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
This was defining aliases of the i32 divrem functions for the i8 and i16 cases. This is unnecessary and was unused. The divrem candidate cases wouldn't have formed with illegal types in the first place, so codegen wouldn't even query these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was defining aliases of the i32 divrem functions for the i8
and i16 cases. This is unnecessary and was unused. The divrem
candidate cases wouldn't have formed with illegal types in the
first place, so codegen wouldn't even query these.