[PowerPC][NFC] Pre-commit test case for checking whether mtvsrbmi power10 instruction not used
#143956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-powerpc Author: zhijian lin (diggerlin) ChangesVerify whether the generated assembly for the following function includes the mtvsrbmi instruction. Full diff: https://github.com/llvm/llvm-project/pull/143956.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/PowerPC/mtvsrbmi.ll b/llvm/test/CodeGen/PowerPC/mtvsrbmi.ll
new file mode 100644
index 0000000000000..7b793c98a57a8
--- /dev/null
+++ b/llvm/test/CodeGen/PowerPC/mtvsrbmi.ll
@@ -0,0 +1,38 @@
+; Verify whether the generated assembly for the following function includes the mtvsrbmi instruction.
+; vector unsigned char v00FF()
+; {
+; vector unsigned char x = { 0xFF, 0,0,0, 0,0,0,0, 0,0,0,0, 0,0,0,0 };
+; return x;
+; }
+
+; RUN: llc < %s -ppc-asm-full-reg-names -mtriple=powerpc-ibm-aix -mcpu=pwr10 -verify-machineinstrs \
+; RUN: | FileCheck %s --check-prefix=CHECK
+
+define dso_local noundef range(i8 -1, 1) <16 x i8> @_Z5v00FFv() local_unnamed_addr {
+entry:
+ ret <16 x i8> <i8 -1, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0, i8 0>
+}
+
+; CHECK: L..CPI0_0:
+; CHECK-NEXT: .byte 255 # 0xff
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+; CHECK-NEXT: .byte 0 # 0x0
+
+; CHECK: ._Z5v00FFv:
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: lwz r3, L..C0(r2)
+; CHECK-NEXT: lxv vs34, 0(r3)
+; CHECK-NEXT: blr
|
diggerlin
changed the title
mtvsrbmi power10 instruction not usedmtvsrbmi power10 instruction not used
lei137
reviewed
Jun 12, 2025
| ; RUN: llc < %s -ppc-asm-full-reg-names -mtriple=powerpc-ibm-aix -mcpu=pwr10 -verify-machineinstrs \ | ||
| ; RUN: | FileCheck %s --check-prefix=CHECK | ||
|
|
||
| define dso_local noundef range(i8 -1, 1) <16 x i8> @_Z5v00FFv() local_unnamed_addr { |
There was a problem hiding this comment.
is dso_local and local_unnamed_addr needed?
In general we prefer to use the update_llc_* utils to generate the checks. If this can't be used, can you please add doc about why?
lei137
approved these changes
Jun 12, 2025
|
The merged test case has error, I have a fix on the patch [PowerPC] fixed mtvsrbmi.ll test case error caused by run the update_llc_test_checks.py |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/21384 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/20241 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/20076 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/20299 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/18226 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/34739 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/20755 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/30186 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/28360 Here is the relevant piece of the build log for the reference |
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…ower10 instruction not used (llvm#143956) Verify whether the generated assembly for the following function includes the mtvsrbmi instruction. vector unsigned char v00FF() { vector unsigned char x = { 0xFF, 0,0,0, 0,0,0,0, 0,0,0,0, 0,0,0,0 }; return x; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify whether the generated assembly for the following function includes the mtvsrbmi instruction.
vector unsigned char v00FF()
{
vector unsigned char x = { 0xFF, 0,0,0, 0,0,0,0, 0,0,0,0, 0,0,0,0 };
return x;
}