Skip to content

[utils] Add "aarch64-apple-macosx" triple to update_llc_test_checks.py #144023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tomershafir
Copy link
Contributor

Add a missing valid triple "aarch64-apple-macosx" for usability.

Add a missing valid triple "aarch64-apple-macosx" for usability.
@llvmbot
Copy link
Member

llvmbot commented Jun 13, 2025

@llvm/pr-subscribers-testing-tools

Author: Tomer Shafir (tomershafir)

Changes

Add a missing valid triple "aarch64-apple-macosx" for usability.


Full diff: https://github.com/llvm/llvm-project/pull/144023.diff

1 Files Affected:

  • (modified) llvm/utils/UpdateTestChecks/asm.py (+1)
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index da7e7ecc24bdc..3754aa2eeba85 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -561,6 +561,7 @@ def get_run_handler(triple):
         "aarch64": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
         "aarch64-apple-darwin": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
         "aarch64-apple-ios": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
+        "aarch64-apple-macosx": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
         "bpf": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),
         "bpfel": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),
         "bpfeb": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),

@tomershafir
Copy link
Contributor Author

@davemgreen can you pls merge? still waiting for commit access

@davemgreen davemgreen merged commit db682a7 into llvm:main Jun 14, 2025
9 checks passed
@tomershafir tomershafir deleted the add-triple-to-update-llc-test-checks branch June 14, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants