Skip to content

Revert "[GlobalISel] Split Legalizer debug ouput into paragraphs. NFC" #144256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Zhenhang1213
Copy link
Contributor

Reverts #143427

@llvmbot
Copy link
Member

llvmbot commented Jun 15, 2025

@llvm/pr-subscribers-llvm-globalisel

Author: Austin (Zhenhang1213)

Changes

Reverts llvm/llvm-project#143427


Full diff: https://github.com/llvm/llvm-project/pull/144256.diff

1 Files Affected:

  • (modified) llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp (+1-1)
diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index 028bffd1bf5a7..83ba71e4c9d49 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -118,7 +118,7 @@ LegalizerHelper::LegalizerHelper(MachineFunction &MF, const LegalizerInfo &LI,
 LegalizerHelper::LegalizeResult
 LegalizerHelper::legalizeInstrStep(MachineInstr &MI,
                                    LostDebugLocObserver &LocObserver) {
-  LLVM_DEBUG(dbgs() << "\nLegalizing: " << MI);
+  LLVM_DEBUG(dbgs() << "Legalizing: " << MI);
 
   MIRBuilder.setInstrAndDebugLoc(MI);
 

@Zhenhang1213 Zhenhang1213 requested a review from davemgreen June 15, 2025 11:06
@davemgreen
Copy link
Collaborator

Hi - Is the patch causing issues anywhere? I'm not sure we need to revert it.

If it is just about the pr being submitted that isn't a problem. I was just about to submit it anyway!

@Zhenhang1213
Copy link
Contributor Author

Hi - Is the patch causing issues anywhere? I'm not sure we need to revert it.

If it is just about the pr being submitted that isn't a problem. I was just about to submit it anyway!

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants