Skip to content

[clang] Add release note for int->enum conversion change. #144407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

efriedma-quic
Copy link
Collaborator

This seems to be having some practical impact, so we should let people know.

This seems to be having some practical impact, so we should let people
know.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 16, 2025

@llvm/pr-subscribers-clang

Author: Eli Friedman (efriedma-quic)

Changes

This seems to be having some practical impact, so we should let people know.


Full diff: https://github.com/llvm/llvm-project/pull/144407.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+3-1)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index b42d5f8425af6..e9455c0756bd9 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -65,8 +65,10 @@ C++ Specific Potentially Breaking Changes
   standard library already have their own bespoke builtins.
 - A workaround for libstdc++4.7 has been removed. Note that 4.8.3 remains the oldest
   supported libstdc++ version.
-
 - Added ``!nonnull/!align`` metadata to load of references for better codegen.
+- Checking for int->enum conversions in constant expressions is more strict;
+  in particular, ``const E x = (E)-1;`` is not treated as a constant if it's
+  out of range. This impacts old versions of Boost.  (#GH143034)
 
 ABI Changes in This Version
 ---------------------------

@efriedma-quic efriedma-quic merged commit 3f33c84 into llvm:main Jun 17, 2025
10 checks passed
fschlimb pushed a commit to fschlimb/llvm-project that referenced this pull request Jun 18, 2025
This seems to be having some practical impact, so we should let people
know.
Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've done this :) (Sorry, going through my WG21 backlog!). It would be neat if we mentioned how to FIX the boost issue/elaborated a bit on summarizing the discussion), but this is fine-as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants