Skip to content

[mlir] mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg #144685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

fschlimb
Copy link
Contributor

Probably an accident in #143108 (@davidegrohmann): The introduced lit.local.cfg basically muted all mlir lit tests.
renamed: mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg

@llvmbot
Copy link
Member

llvmbot commented Jun 18, 2025

@llvm/pr-subscribers-mlir-spirv

@llvm/pr-subscribers-mlir

Author: Frank Schlimbach (fschlimb)

Changes

Probably an accident in #143108 (@davidegrohmann): The introduced lit.local.cfg basically muted all mlir lit tests.
renamed: mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg


Full diff: https://github.com/llvm/llvm-project/pull/144685.diff

1 Files Affected:

  • (renamed) mlir/test/Target/SPIRV/lit.local.cfg ()
diff --git a/mlir/test/lit.local.cfg b/mlir/test/Target/SPIRV/lit.local.cfg
similarity index 100%
rename from mlir/test/lit.local.cfg
rename to mlir/test/Target/SPIRV/lit.local.cfg

Copy link
Member

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM.

@fschlimb fschlimb merged commit 8584abb into llvm:main Jun 18, 2025
10 checks passed
fschlimb added a commit to fschlimb/llvm-project that referenced this pull request Jun 18, 2025
llvm#144685)

renamed: mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg
kuhar added a commit that referenced this pull request Jun 18, 2025
…lizing" and follow up commits (#144773)

This reverts the following PRs:
* #143108
* #144538
* #144685

Reverting because this disabled tests when building without the llvm
spirv backend enabled.
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Jun 18, 2025
… when serializing" and follow up commits (#144773)

This reverts the following PRs:
* llvm/llvm-project#143108
* llvm/llvm-project#144538
* llvm/llvm-project#144685

Reverting because this disabled tests when building without the llvm
spirv backend enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants