[llvm] explicitly link llvm-jitlink-executor with ExecutionEngine #144778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd here's a super quick one, thanks! |
compnerd
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Explicitly link
llvm-jitlink-executorwithExecutionEngineto avoid link failures when building LLVM as a Windows DLL. This link dependency should probably have always been declared here, but didn't matter when building against an LLVM static library because it was (presumably) picked up as a transitive dependency.This change is required to enable the Windows DLL build because
llvm-jitlink-executoris declared usingadd_llvm_utilitywhich invokesadd_llvm_executablewithDISABLE_LLVM_LINK_LLVM_DYLIBso it links statically against its dependencies instead of against the main LLVM library.Background
The effort to support building LLVM as a Windows DLL is tracked in #109483. Additional context is provided in this discourse.