-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[AMDGPU] Allow dpp in v_pk_fmac_f16 for GFX9 and GFX10 #144782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jwanggit86
merged 7 commits into
llvm:main
from
jwanggit86:allow-dpp-in-v_pk_fmac_f16-for-gfx9-gfx10
Jun 24, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c51f487
[AMDGPU] Allow dpp in v_pk_fmac_f16 for GFX9 and GFX10
jwanggit86 76a36b2
for gfx9, use existing VOP2_Real_e32e64_gfx9
jwanggit86 e16fa23
for gfx10, use existing VOP2_Real_gfx10
jwanggit86 bccf7eb
Revert "for gfx10, use existing VOP2_Real_gfx10"
jwanggit86 e9acb6c
GFX9 has SDWA instruction while GFX10 does not. Add tests to
jwanggit86 ff2c368
(1) A new multiclass for gfx10 (2) tests for disassembler
jwanggit86 39fcf97
Combine two defs into one
jwanggit86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx908 -show-encoding %s | FileCheck --check-prefix=CHECK-MI %s | ||
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx90a -show-encoding %s | FileCheck --check-prefix=CHECK-MI %s | ||
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx942 -show-encoding %s | FileCheck --check-prefix=CHECK-MI %s | ||
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx950 -show-encoding %s | FileCheck --check-prefix=CHECK-MI %s | ||
|
||
v_pk_fmac_f16 v5, v1, v2 | ||
// CHECK-MI: [0x01,0x05,0x0a,0x78] | ||
|
||
v_pk_fmac_f16 v5, v1, v2 quad_perm:[0,1,2,3] | ||
// CHECK-MI: [0xfa,0x04,0x0a,0x78,0x01,0xe4,0x00,0xff] | ||
|
||
v_pk_fmac_f16 v5, v1, v2 quad_perm:[0,1,2,3] row_mask:0x0 bank_mask:0x0 | ||
// CHECK-MI: [0xfa,0x04,0x0a,0x78,0x01,0xe4,0x00,0x00] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_0 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x00,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_1 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x01,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_2 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x02,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_3 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x03,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:WORD_0 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x04,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:WORD_1 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x05,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_SEXT src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x0e,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x16,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x16,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_0 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x00,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_1 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x01,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_2 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x02,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_3 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x03,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x04,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1 src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x05,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_0 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x00] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_1 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x01] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_2 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x02] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_3 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x03] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x04] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_1 | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x05] | ||
|
||
v_pk_fmac_f16_sdwa v5, v1, sext(v2) dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
// CHECK-MI: [0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x16] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
# RUN: llvm-mc -triple=amdgcn -mcpu=gfx908 -disassemble -show-encoding < %s | FileCheck -check-prefix=CHECK-MI %s | ||
# RUN: llvm-mc -triple=amdgcn -mcpu=gfx90a -disassemble -show-encoding < %s | FileCheck -check-prefix=CHECK-MI %s | ||
# RUN: llvm-mc -triple=amdgcn -mcpu=gfx942 -disassemble -show-encoding < %s | FileCheck -check-prefix=CHECK-MI %s | ||
# RUN: llvm-mc -triple=amdgcn -mcpu=gfx950 -disassemble -show-encoding < %s | FileCheck -check-prefix=CHECK-MI %s | ||
|
||
# CHECK-MI: v_pk_fmac_f16_e32 v5, v1, v2 | ||
0x01,0x05,0x0a,0x78 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_dpp v5, v1, v2 quad_perm:[0,1,2,3] row_mask:0xf bank_mask:0xf | ||
0xfa,0x04,0x0a,0x78,0x01,0xe4,0x00,0xff | ||
|
||
# CHECK-MI: v_pk_fmac_f16_dpp v5, v1, v2 quad_perm:[0,1,2,3] row_mask:0x0 bank_mask:0x0 | ||
0xfa,0x04,0x0a,0x78,0x01,0xe4,0x00,0x00 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_0 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x00,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_1 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x01,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_2 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x02,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:BYTE_3 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x03,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:WORD_0 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x04,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:WORD_1 dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x05,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_SEXT src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x0e,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x16,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x16,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_0 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x00,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_1 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x01,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_2 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x02,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:BYTE_3 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x03,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x04,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1 src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x05,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x06 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_0 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x00 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_1 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x01 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_2 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x02 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:BYTE_3 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x03 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x04 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_1 | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x05 | ||
|
||
# CHECK-MI: v_pk_fmac_f16_sdwa v5, v1, sext(v2) dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:DWORD | ||
0xf9,0x04,0x0a,0x78,0x01,0x06,0x06,0x16 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdwa disasm tests needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.