[mlir][Transforms] Dialect Conversion: Simplify block-inline handling #145308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesWhen a block is getting inlined, the destination block does not have to be legalized. That's because the signature of the destination block does not change by inlining. This commit makes the implementation consistent with this comment: Full diff: https://github.com/llvm/llvm-project/pull/145308.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 9cb6f2ba1eaae..7cfe7250d02c3 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2301,7 +2301,7 @@ LogicalResult OperationLegalizer::legalizePatternBlockRewrites(
continue;
Block *block = rewrite->getBlock();
if (isa<BlockTypeConversionRewrite, EraseBlockRewrite,
- ReplaceBlockArgRewrite>(rewrite))
+ ReplaceBlockArgRewrite, InlineBlockRewrite>(rewrite))
continue;
// Only check blocks outside of the current operation.
Operation *parentOp = block->getParentOp();
|
|
@llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) ChangesWhen a block is getting inlined, the destination block does not have to be legalized. That's because the signature of the destination block does not change by inlining. This commit makes the implementation consistent with this comment: Full diff: https://github.com/llvm/llvm-project/pull/145308.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 9cb6f2ba1eaae..7cfe7250d02c3 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2301,7 +2301,7 @@ LogicalResult OperationLegalizer::legalizePatternBlockRewrites(
continue;
Block *block = rewrite->getBlock();
if (isa<BlockTypeConversionRewrite, EraseBlockRewrite,
- ReplaceBlockArgRewrite>(rewrite))
+ ReplaceBlockArgRewrite, InlineBlockRewrite>(rewrite))
continue;
// Only check blocks outside of the current operation.
Operation *parentOp = block->getParentOp();
|
j2kun
approved these changes
Jun 23, 2025
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
…llvm#145308) When a block is getting inlined, the destination block does not have to be legalized. That's because the signature of the destination block does not change by inlining. This commit makes the implementation consistent with this comment: ``` // If the pattern moved or created any blocks, make sure the types of block // arguments get legalized. ```
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…llvm#145308) When a block is getting inlined, the destination block does not have to be legalized. That's because the signature of the destination block does not change by inlining. This commit makes the implementation consistent with this comment: ``` // If the pattern moved or created any blocks, make sure the types of block // arguments get legalized. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block is getting inlined, the destination block does not have to be legalized. That's because the signature of the destination block does not change by inlining.
This commit makes the implementation consistent with this comment: