Skip to content

[llvm] annotate remaining ExecutionEngine, Frontend, and TargetParser interfaces for DLL export #145367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/include/llvm/ExecutionEngine/Orc/COFF.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#ifndef LLVM_EXECUTIONENGINE_ORC_COFF_H
#define LLVM_EXECUTIONENGINE_ORC_COFF_H

#include "llvm/Support/Compiler.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/MemoryBuffer.h"

Expand All @@ -31,8 +32,8 @@ class COFFImportFileScanner {
public:
COFFImportFileScanner(std::set<std::string> &ImportedDynamicLibraries)
: ImportedDynamicLibraries(ImportedDynamicLibraries) {}
Expected<bool> operator()(object::Archive &A, MemoryBufferRef MemberBuf,
size_t Index) const;
LLVM_ABI Expected<bool>
operator()(object::Archive &A, MemoryBufferRef MemberBuf, size_t Index) const;

private:
std::set<std::string> &ImportedDynamicLibraries;
Expand Down
4 changes: 3 additions & 1 deletion llvm/include/llvm/Frontend/Directive/Spelling.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/iterator_range.h"
#include "llvm/Support/Compiler.h"

#include <limits>
#include <tuple>
Expand All @@ -33,7 +34,8 @@ struct Spelling {
VersionRange Versions;
};

StringRef FindName(llvm::iterator_range<const Spelling *>, unsigned Version);
LLVM_ABI StringRef FindName(llvm::iterator_range<const Spelling *>,
unsigned Version);

} // namespace llvm::directive

Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/Frontend/Driver/CodeGenOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ enum ProfileInstrKind {
};

// Default filename used for profile generation.
std::string getDefaultProfileGenName();
LLVM_ABI std::string getDefaultProfileGenName();
} // end namespace llvm::driver

#endif
9 changes: 5 additions & 4 deletions llvm/include/llvm/Frontend/HLSL/HLSLRootSignatureUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,14 @@ class ResourceRange {

// Returns a reference to the first RangeInfo that overlaps with
// [Info.LowerBound;Info.UpperBound], or, std::nullopt if there is no overlap
std::optional<const RangeInfo *> getOverlapping(const RangeInfo &Info) const;
LLVM_ABI std::optional<const RangeInfo *>
getOverlapping(const RangeInfo &Info) const;

// Return the mapped RangeInfo at X or nullptr if no mapping exists
const RangeInfo *lookup(uint32_t X) const;
LLVM_ABI const RangeInfo *lookup(uint32_t X) const;

// Removes all entries of the ResourceRange
void clear();
LLVM_ABI void clear();

// Insert the required (sub-)intervals such that the interval of [a;b] =
// [Info.LowerBound, Info.UpperBound] is covered and points to a valid
Expand Down Expand Up @@ -131,7 +132,7 @@ class ResourceRange {
// Returns a reference to the first RangeInfo that overlaps with
// [Info.LowerBound;Info.UpperBound], or, std::nullopt if there is no overlap
// (equivalent to getOverlapping)
std::optional<const RangeInfo *> insert(const RangeInfo &Info);
LLVM_ABI std::optional<const RangeInfo *> insert(const RangeInfo &Info);
};

} // namespace rootsig
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/TargetParser/TargetParser.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ struct BasicSubtargetSubTypeKV {
}
};

std::optional<llvm::StringMap<bool>>
LLVM_ABI std::optional<llvm::StringMap<bool>>
getCPUDefaultTargetFeatures(StringRef CPU,
ArrayRef<BasicSubtargetSubTypeKV> ProcDesc,
ArrayRef<BasicSubtargetFeatureKV> ProcFeatures);
Expand Down