[DirectX] Make firstbithigh intrinsic use first arg as overload type #145401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-directx Author: Ashley Coleman (V-FEXrt) ChangesSibling to #145350 part of #144966 Full diff: https://github.com/llvm/llvm-project/pull/145401.diff 3 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DirectXTargetTransformInfo.cpp b/llvm/lib/Target/DirectX/DirectXTargetTransformInfo.cpp
index 84b2603b4c575..ffd900c68893f 100644
--- a/llvm/lib/Target/DirectX/DirectXTargetTransformInfo.cpp
+++ b/llvm/lib/Target/DirectX/DirectXTargetTransformInfo.cpp
@@ -31,6 +31,8 @@ bool DirectXTTIImpl::isTargetIntrinsicWithOverloadTypeAtArg(Intrinsic::ID ID,
case Intrinsic::dx_asdouble:
case Intrinsic::dx_isinf:
case Intrinsic::dx_firstbitlow:
+ case Intrinsic::dx_firstbituhigh:
+ case Intrinsic::dx_firstbitshigh:
return OpdIdx == 0;
default:
return OpdIdx == -1;
diff --git a/llvm/test/CodeGen/DirectX/firstbithigh.ll b/llvm/test/CodeGen/DirectX/firstbithigh.ll
index 794b0f20a0269..3f4a75307c9b5 100644
--- a/llvm/test/CodeGen/DirectX/firstbithigh.ll
+++ b/llvm/test/CodeGen/DirectX/firstbithigh.ll
@@ -4,42 +4,42 @@
define noundef i32 @test_firstbithigh_ushort(i16 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i16(i32 33, i16 %{{.*}}) #[[#ATTR:]]
+; CHECK: call i32 @dx.op.unaryBits.i16(i32 33, i16 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i16(i16 %a)
ret i32 %elt.firstbithigh
}
define noundef i32 @test_firstbithigh_short(i16 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i16(i32 34, i16 %{{.*}}) #[[#ATTR]]
+; CHECK: call i32 @dx.op.unaryBits.i16(i32 34, i16 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i16(i16 %a)
ret i32 %elt.firstbithigh
}
define noundef i32 @test_firstbithigh_uint(i32 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i32(i32 33, i32 %{{.*}}) #[[#ATTR]]
+; CHECK: call i32 @dx.op.unaryBits.i32(i32 33, i32 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i32(i32 %a)
ret i32 %elt.firstbithigh
}
define noundef i32 @test_firstbithigh_int(i32 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i32(i32 34, i32 %{{.*}}) #[[#ATTR]]
+; CHECK: call i32 @dx.op.unaryBits.i32(i32 34, i32 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i32(i32 %a)
ret i32 %elt.firstbithigh
}
define noundef i32 @test_firstbithigh_ulong(i64 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i64(i32 33, i64 %{{.*}}) #[[#ATTR]]
+; CHECK: call i32 @dx.op.unaryBits.i64(i32 33, i64 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbituhigh.i64(i64 %a)
ret i32 %elt.firstbithigh
}
define noundef i32 @test_firstbithigh_long(i64 noundef %a) {
entry:
-; CHECK: call i32 @dx.op.unaryBits.i64(i32 34, i64 %{{.*}}) #[[#ATTR]]
+; CHECK: call i32 @dx.op.unaryBits.i64(i32 34, i64 %{{.*}})
%elt.firstbithigh = call i32 @llvm.dx.firstbitshigh.i64(i64 %a)
ret i32 %elt.firstbithigh
}
@@ -47,17 +47,18 @@ entry:
define noundef <4 x i32> @test_firstbituhigh_vec4_i32(<4 x i32> noundef %a) {
entry:
; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0
- ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee0]]) #[[#ATTR]]
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1
- ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee1]]) #[[#ATTR]]
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee1]])
; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2
- ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee2]]) #[[#ATTR]]
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
- ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee3]]) #[[#ATTR]]
- ; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 33, i32 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i32(<4 x i32> %a)
ret <4 x i32> %2
}
@@ -65,29 +66,95 @@ entry:
define noundef <4 x i32> @test_firstbitshigh_vec4_i32(<4 x i32> noundef %a) {
entry:
; CHECK: [[ee0:%.*]] = extractelement <4 x i32> %a, i64 0
- ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee0]]) #[[#ATTR]]
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee0]])
; CHECK: [[ee1:%.*]] = extractelement <4 x i32> %a, i64 1
- ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee1]]) #[[#ATTR]]
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee1]])
; CHECK: [[ee2:%.*]] = extractelement <4 x i32> %a, i64 2
- ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee2]]) #[[#ATTR]]
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
- ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee3]]) #[[#ATTR]]
- ; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 34, i32 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i32(<4 x i32> %a)
ret <4 x i32> %2
}
-; CHECK: attributes #[[#ATTR]] = {{{.*}} memory(none) {{.*}}}
+define noundef <4 x i32> @test_firstbituhigh_vec4_i16(<4 x i16> noundef %a) {
+entry:
+ ; CHECK: [[ee0:%.*]] = extractelement <4 x i16> %a, i64 0
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee0]])
+ ; CHECK: [[ee1:%.*]] = extractelement <4 x i16> %a, i64 1
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee1]])
+ ; CHECK: [[ee2:%.*]] = extractelement <4 x i16> %a, i64 2
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee2]])
+ ; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 33, i16 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
+ %2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i16(<4 x i16> %a)
+ ret <4 x i32> %2
+}
-declare i32 @llvm.dx.firstbituhigh.i16(i16)
-declare i32 @llvm.dx.firstbituhigh.i32(i32)
-declare i32 @llvm.dx.firstbituhigh.i64(i64)
-declare <4 x i32> @llvm.dx.firstbituhigh.v4i32(<4 x i32>)
+define noundef <4 x i32> @test_firstbitshigh_vec4_i16(<4 x i16> noundef %a) {
+entry:
+ ; CHECK: [[ee0:%.*]] = extractelement <4 x i16> %a, i64 0
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee0]])
+ ; CHECK: [[ee1:%.*]] = extractelement <4 x i16> %a, i64 1
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee1]])
+ ; CHECK: [[ee2:%.*]] = extractelement <4 x i16> %a, i64 2
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee2]])
+ ; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 34, i16 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
+ %2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i16(<4 x i16> %a)
+ ret <4 x i32> %2
+}
-declare i32 @llvm.dx.firstbitshigh.i16(i16)
-declare i32 @llvm.dx.firstbitshigh.i32(i32)
-declare i32 @llvm.dx.firstbitshigh.i64(i64)
-declare <4 x i32> @llvm.dx.firstbitshigh.v4i32(<4 x i32>)
+define noundef <4 x i32> @test_firstbituhigh_vec4_i64(<4 x i64> noundef %a) {
+entry:
+ ; CHECK: [[ee0:%.*]] = extractelement <4 x i64> %a, i64 0
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i64(i32 33, i64 [[ee0]])
+ ; CHECK: [[ee1:%.*]] = extractelement <4 x i64> %a, i64 1
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i64(i32 33, i64 [[ee1]])
+ ; CHECK: [[ee2:%.*]] = extractelement <4 x i64> %a, i64 2
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i64(i32 33, i64 [[ee2]])
+ ; CHECK: [[ee3:%.*]] = extractelement <4 x i64> %a, i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i64(i32 33, i64 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
+ %2 = call <4 x i32> @llvm.dx.firstbituhigh.v4i64(<4 x i64> %a)
+ ret <4 x i32> %2
+}
+
+define noundef <4 x i32> @test_firstbitshigh_vec4_i64(<4 x i64> noundef %a) {
+entry:
+ ; CHECK: [[ee0:%.*]] = extractelement <4 x i64> %a, i64 0
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i64(i32 34, i64 [[ee0]])
+ ; CHECK: [[ee1:%.*]] = extractelement <4 x i64> %a, i64 1
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i64(i32 34, i64 [[ee1]])
+ ; CHECK: [[ee2:%.*]] = extractelement <4 x i64> %a, i64 2
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i64(i32 34, i64 [[ee2]])
+ ; CHECK: [[ee3:%.*]] = extractelement <4 x i64> %a, i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i64(i32 34, i64 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
+ ; CHECK: fex
+ %2 = call <4 x i32> @llvm.dx.firstbitshigh.v4i64(<4 x i64> %a)
+ ret <4 x i32> %2
+}
diff --git a/llvm/test/CodeGen/DirectX/firstbitlow.ll b/llvm/test/CodeGen/DirectX/firstbitlow.ll
index fe3786d3fbebf..81a10d037835e 100644
--- a/llvm/test/CodeGen/DirectX/firstbitlow.ll
+++ b/llvm/test/CodeGen/DirectX/firstbitlow.ll
@@ -33,10 +33,11 @@ entry:
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i32> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i32(i32 32, i32 [[ee3]])
- ; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitlow.v4i32(<4 x i32> %a)
ret <4 x i32> %2
}
@@ -51,10 +52,30 @@ entry:
; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee2]])
; CHECK: [[ee3:%.*]] = extractelement <4 x i16> %a, i64 3
; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i16(i32 32, i16 [[ee3]])
- ; CHECK: insertelement <4 x i32> poison, i32 [[ie0]], i64 0
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie1]], i64 1
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie2]], i64 2
- ; CHECK: insertelement <4 x i32> %{{.*}}, i32 [[ie3]], i64 3
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
%2 = call <4 x i32> @llvm.dx.firstbitlow.v4i16(<4 x i16> %a)
ret <4 x i32> %2
}
+
+define noundef <4 x i32> @test_firstbitlow_vec4_i64(<4 x i64> noundef %a) {
+entry:
+ ; CHECK: [[ee0:%.*]] = extractelement <4 x i64> %a, i64 0
+ ; CHECK: [[ie0:%.*]] = call i32 @dx.op.unaryBits.i64(i32 32, i64 [[ee0]])
+ ; CHECK: [[ee1:%.*]] = extractelement <4 x i64> %a, i64 1
+ ; CHECK: [[ie1:%.*]] = call i32 @dx.op.unaryBits.i64(i32 32, i64 [[ee1]])
+ ; CHECK: [[ee2:%.*]] = extractelement <4 x i64> %a, i64 2
+ ; CHECK: [[ie2:%.*]] = call i32 @dx.op.unaryBits.i64(i32 32, i64 [[ee2]])
+ ; CHECK: [[ee3:%.*]] = extractelement <4 x i64> %a, i64 3
+ ; CHECK: [[ie3:%.*]] = call i32 @dx.op.unaryBits.i64(i32 32, i64 [[ee3]])
+ ; CHECK: [[rt0:%.*]] = insertelement <4 x i32> poison, i32 [[ie0]], i64 0
+ ; CHECK: [[rt1:%.*]] = insertelement <4 x i32> [[rt0]], i32 [[ie1]], i64 1
+ ; CHECK: [[rt2:%.*]] = insertelement <4 x i32> [[rt1]], i32 [[ie2]], i64 2
+ ; CHECK: [[rt3:%.*]] = insertelement <4 x i32> [[rt2]], i32 [[ie3]], i64 3
+ ; CHECK: ret <4 x i32> [[rt3]]
+ %2 = call <4 x i32> @llvm.dx.firstbitlow.v4i64(<4 x i64> %a)
+ ret <4 x i32> %2
+}
|
bogner
approved these changes
Jun 23, 2025
spall
approved these changes
Jun 23, 2025
farzonl
reviewed
Jun 23, 2025
farzonl
approved these changes
Jun 23, 2025
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
…lvm#145401) Sibling to llvm#145350 part of llvm#144966 firstbituhigh and firstbitshigh should use the first arg for overloads instead of the return type since the return is always i32
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…lvm#145401) Sibling to llvm#145350 part of llvm#144966 firstbituhigh and firstbitshigh should use the first arg for overloads instead of the return type since the return is always i32
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
…lvm#145401) Sibling to llvm#145350 part of llvm#144966 firstbituhigh and firstbitshigh should use the first arg for overloads instead of the return type since the return is always i32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to #145350 part of #144966
firstbituhigh and firstbitshigh should use the first arg for overloads instead of the return type since the return is always i32