Skip to content

[lldb][rpc] Fix bug in convert script for RPC #145419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

[lldb][rpc] Fix bug in convert script for RPC #145419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/scripts/convert-lldb-header-to-rpc-header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
LLDB_NAMESPACE_DEFINITION_REGEX = re.compile(
r"(?P<comment_marker>//\s*){,1}namespace lldb\s{1}", re.M
)
LLDB_NAMESPACE_REGEX = re.compile(r"\s*.+lldb::\s*", re.M)
LLDB_NAMESPACE_REGEX = re.compile(r"lldb::\s*", re.M)


def main():
Expand Down
3 changes: 3 additions & 0 deletions lldb/test/Shell/RPC/Scripts/TestConvertScript/CheckLLDBEnumerations.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,8 @@ CHECK: #define LLDB_RPC_ENUMERATIONS_H
# Change the namespace to lldb_rpc. Also, the comment that closes the namespace should match the namespace.
CHECK: namespace lldb_rpc {} // namespace lldb_rpc

# When the lldb namespace is used, the namespace must be replaced with lldb_rpc.
CHECK: void dummyFunction(lldb_rpc::addr_t) {}

# The comment that closes the include guard should match the guard.
CHECK: #endif // LLDB_RPC_ENUMERATIONS_H
3 changes: 3 additions & 0 deletions lldb/test/Shell/RPC/Scripts/TestConvertScript/Inputs/lldb-enumerations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// namespace lldb -> namespace lldb_rpc
namespace lldb {} // namespace lldb

// When the lldb namespace is used, the namespace must be replaced with lldb_rpc.
void dummyFunction(lldb::addr_t) {}

// The comment that closes the include guard must change in the same way
// the original guard did:
// #endif // LLDB_LLDB_ENUMERATIONS_H -> #endif // LLDB_RPC_ENUMERATIONS_H
Expand Down
Loading