Skip to content

[analyzer][NFC] Add xrefs to a test case that has poor git blame #145501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

balazs-benics-sonarsource
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 24, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 24, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Balázs Benics (balazs-benics-sonarsource)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/145501.diff

1 Files Affected:

  • (modified) clang/test/Analysis/PR38208.c (+5)
diff --git a/clang/test/Analysis/PR38208.c b/clang/test/Analysis/PR38208.c
index fb0a5a15eac6b..750cbc50cc749 100644
--- a/clang/test/Analysis/PR38208.c
+++ b/clang/test/Analysis/PR38208.c
@@ -2,6 +2,11 @@
 
 // expected-no-diagnostics
 
+// This test case used to demonstrate a huge slowdown regression.
+// Reported in https://bugs.llvm.org/show_bug.cgi?id=38208
+// Caused by 2bbccca9f75b6bce08d77cf19abfb206d0c3bc2e aka. "aggressive-binary-operation-simplification"
+// Fixed by dcde8acc32f1355f37d3bc2814c528fdc2ca5f94
+
 int foo(int a, int b) {
   a += b; b -= a;
   a += b; b -= a;

@balazs-benics-sonarsource
Copy link
Contributor Author

I wanted to look at recently of the history of this test file. I managed to dig it up, but since the git blame didn't tell me much I think it's worth to spell out these refs explicitly.

@balazs-benics-sonarsource balazs-benics-sonarsource merged commit e04c938 into llvm:main Jun 24, 2025
10 checks passed
@balazs-benics-sonarsource balazs-benics-sonarsource deleted the bb/attribute-test-case branch June 24, 2025 12:50
DrSergei pushed a commit to DrSergei/llvm-project that referenced this pull request Jun 24, 2025
anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:static analyzer clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants