[bazel] Add //mlir:IR to Support for #144897 #145569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#144897 added #include "mlir/IR/Visitors.h" to mlir/include/mlir/Support/StateStack.h. This change fixes the build file.
rupprecht
approved these changes
Jun 24, 2025
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
PR llvm#144897 added #include "mlir/IR/Visitors.h" to mlir/include/mlir/Support/StateStack.h. This change fixes the build file.
thevinster
reviewed
Jun 25, 2025
| deps = ["//llvm:Support"], | ||
| deps = [ | ||
| "//llvm:Support" | ||
| "//mlir:IR", |
There was a problem hiding this comment.
Correct me if I'm wrong here, but doesn't this introduce a cycle? The IR target already depends on Support which then depends on the IR target again. Is there any way to refactor to avoid the cyclic dependency here?
There was a problem hiding this comment.
The cycle already existed. Being fixed on #145598
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
PR llvm#144897 added #include "mlir/IR/Visitors.h" to mlir/include/mlir/Support/StateStack.h. This change fixes the build file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #144897 added #include "mlir/IR/Visitors.h" to mlir/include/mlir/Support/StateStack.h. This change fixes the build file.