[NFC][AsmPrinter] Rework/add comments #145587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slinder1
commented
Jun 24, 2025
slinder1
commented
- Add a comment explaining TrackedRegs cache in handleNewDebugValue
- Remove a comment which is not meaningful since https://reviews.llvm.org/D4919
- Expand the subject of a comment to match the code it describes
- Add a comment explaining TrackedRegs cache in handleNewDebugValue - Remove a comment which is not meaningful since https://reviews.llvm.org/D4919 - Expand the subject of a comment to match the code it describes
slinder1
requested review from
jmorse,
adrian-prantl,
SLTozer,
epilk,
OCHyams and
kzhuravl
This was referenced Jun 24, 2025
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
- Add a comment explaining TrackedRegs cache in handleNewDebugValue - Remove a comment which is not meaningful since https://reviews.llvm.org/D4919 - Expand the subject of a comment to match the code it describes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.