Handle vendor string in match for clang version string #145612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Dave Bartolomeo (dbartol) Changes#145455 failed to account for the optional "vendor string" that precedes the Full diff: https://github.com/llvm/llvm-project/pull/145612.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/pragma-comment.c b/clang/test/CodeGen/pragma-comment.c
index 861fba9aece3b..aa3aba18b9b2c 100644
--- a/clang/test/CodeGen/pragma-comment.c
+++ b/clang/test/CodeGen/pragma-comment.c
@@ -34,4 +34,4 @@
// ELF-NOT: foo
// This following match prevents the clang version metadata from matching the forbidden 'foo' and 'bar' tokens.
// This can happen if the clang version string contains a Git repo URL that includes one of those substrings.
-// ELF-LABEL: !"clang version
+// ELF-LABEL: {{\!\".*clang version}}
|
|
@Sharjeel-Khan This should handle any vendor string before |
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
llvm#145455 failed to account for the optional "vendor string" that precedes the `clang version` in the Clang version string metadata. I just updated it to use a regex to allow arbitrary content before the `clang version`. Tested this both with and without a vendor string, and it seems to work as expected.
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
llvm#145455 failed to account for the optional "vendor string" that precedes the `clang version` in the Clang version string metadata. I just updated it to use a regex to allow arbitrary content before the `clang version`. Tested this both with and without a vendor string, and it seems to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#145455 failed to account for the optional "vendor string" that precedes the
clang versionin the Clang version string metadata. I just updated it to use a regex to allow arbitrary content before theclang version. Tested this both with and without a vendor string, and it seems to work as expected.