Revert "[clang][dataflow] Expose simple access to child StorageLocation presence." #145710
Conversation
…on prese…" This reverts commit 09b43a5.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Samira Bakon (bazuzi) ChangesReverts llvm/llvm-project#145520 Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by Full diff: https://github.com/llvm/llvm-project/pull/145710.diff 1 Files Affected:
diff --git a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
index 8b263b16d5b1e..8fcc6a44027a0 100644
--- a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
+++ b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
@@ -168,8 +168,6 @@ class RecordStorageLocation final : public StorageLocation {
return {Children.begin(), Children.end()};
}
- bool hasChild(const ValueDecl &D) const { return Children.contains(&D); }
-
private:
FieldToLoc Children;
SyntheticFieldMap SyntheticFields;
|
|
@llvm/pr-subscribers-clang-analysis Author: Samira Bakon (bazuzi) ChangesReverts llvm/llvm-project#145520 Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by Full diff: https://github.com/llvm/llvm-project/pull/145710.diff 1 Files Affected:
diff --git a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
index 8b263b16d5b1e..8fcc6a44027a0 100644
--- a/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
+++ b/clang/include/clang/Analysis/FlowSensitive/StorageLocation.h
@@ -168,8 +168,6 @@ class RecordStorageLocation final : public StorageLocation {
return {Children.begin(), Children.end()};
}
- bool hasChild(const ValueDecl &D) const { return Children.contains(&D); }
-
private:
FieldToLoc Children;
SyntheticFieldMap SyntheticFields;
|
|
This reverts a simple change added <24 hours ago and reverting has been discussed directly with original change reviewers. Merging without additional review. |
…on presence." (llvm#145710) Reverts llvm#145520 Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by `getModeledFields()` and presence shouldn't need to be queried for arbitrary fields.
…on presence." (llvm#145710) Reverts llvm#145520 Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by `getModeledFields()` and presence shouldn't need to be queried for arbitrary fields.
Reverts #145520
Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by
getModeledFields()and presence shouldn't need to be queried for arbitrary fields.