Skip to content

[AArch64] Do not generate ld1IndexPost when inserting into lane 0 of a zero vector #145723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

[AArch64] Do not generate ld1IndexPost when inserting into lane 0 of a zero vector #145723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23395,6 +23395,8 @@ static SDValue performPostLD1Combine(SDNode *N,
auto *LaneC = dyn_cast<ConstantSDNode>(Lane);
if (!LaneC || LaneC->getZExtValue() >= VT.getVectorNumElements())
return SDValue();
if (LaneC->getZExtValue() == 0 && isNullOrNullSplat(N->getOperand(0)))
return SDValue();
}

LoadSDNode *LoadSDN = cast<LoadSDNode>(LD);
Expand Down
20 changes: 9 additions & 11 deletions llvm/test/CodeGen/AArch64/arm64-indexed-vector-ldst.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13340,9 +13340,9 @@ define <16 x i8> @test_v16i8_post_reg_ld1lane(ptr %bar, ptr %ptr, i64 %inc, <16
define <16 x i8> @test_v16i8_post_reg_ld1lane_zero(ptr %bar, ptr %ptr, i64 %inc) {
; CHECK-SD-LABEL: test_v16i8_post_reg_ld1lane_zero:
; CHECK-SD: ; %bb.0:
; CHECK-SD-NEXT: movi.2d v0, #0000000000000000
; CHECK-SD-NEXT: ld1.b { v0 }[0], [x0], x2
; CHECK-SD-NEXT: str x0, [x1]
; CHECK-SD-NEXT: ldr b0, [x0]
; CHECK-SD-NEXT: add x8, x0, x2
; CHECK-SD-NEXT: str x8, [x1]
; CHECK-SD-NEXT: ret
;
; CHECK-GI-LABEL: test_v16i8_post_reg_ld1lane_zero:
Expand Down Expand Up @@ -14133,17 +14133,15 @@ define i32 @load_single_extract_variable_index_masked2_i32(ptr %A, i32 %idx) {
define void @chained_insert_zero(ptr noundef %fenc, ptr noundef %pred, ptr noundef %residual, i32 noundef %stride) {
; CHECK-SD-LABEL: chained_insert_zero:
; CHECK-SD: ; %bb.0: ; %entry
; CHECK-SD-NEXT: movi.2d v0, #0000000000000000
; CHECK-SD-NEXT: movi.2d v1, #0000000000000000
; CHECK-SD-NEXT: ldr s0, [x1]
; CHECK-SD-NEXT: ldr s1, [x0]
; CHECK-SD-NEXT: ; kill: def $w3 killed $w3 def $x3
; CHECK-SD-NEXT: sxtw x8, w3
; CHECK-SD-NEXT: ld1.s { v0 }[0], [x0], x8
; CHECK-SD-NEXT: ld1.s { v1 }[0], [x1], x8
; CHECK-SD-NEXT: sbfiz x8, x3, #1, #32
; CHECK-SD-NEXT: usubl.8h v0, v0, v1
; CHECK-SD-NEXT: usubl.8h v0, v1, v0
; CHECK-SD-NEXT: str d0, [x2]
; CHECK-SD-NEXT: ldr s0, [x0]
; CHECK-SD-NEXT: ldr s1, [x1]
; CHECK-SD-NEXT: ldr s0, [x0, x8]
; CHECK-SD-NEXT: ldr s1, [x1, x8]
; CHECK-SD-NEXT: sbfiz x8, x3, #1, #32
; CHECK-SD-NEXT: usubl.8h v0, v0, v1
; CHECK-SD-NEXT: str d0, [x2, x8]
; CHECK-SD-NEXT: ret
Expand Down
Loading