Add modified runtimes back to runtimes_to_{test|build} #145805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I forgot about the libc case here. We should probably have a test in compue_projects_test specifically for libc. We have this purposefully disabled for libcxx because they have their own premerge and it was disabled previously, although I've been meaning to put up a patch to enable it at some point soon.
For libc specifically I think it would be best to solve this by just adding an entry for libc in DEPENDENT_RUNTIMES_TO_TEST, just mapping libc to libc. You might also need to setup the dependencies so that clang gets built. A new unittest would also be great.
|
Oh, ok, good to know. looks like dependencies for libc are already set to clang;lld. |
boomanaiden154
approved these changes
Jun 25, 2025
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
Add libc back into the runtimes_to_test since other runtimes were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add libc back into the runtimes_to_test since other runtimes were removed.