[llvm-debuginfo-analyzer] Fix incorrect REQUIRES in WebAssembly test case #145848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…141616) llvm#136772 Incorrect handling of 'tombstone' value for WebAssembly. llvm-debuginfo-analyzer already uses the tombstone approach to identify dead code. Currently, the tombstone value is evaluated as std::numeric_limits<uint64_t>::max(). Which is wrong as it does not take into account the 'Address Byte Size' from the Compile Unit header. Fix incorrect 'REQUIRES'. The correct value should be: REQUIRES: webassembly-registered-target
CarlosAlbertoEnciso
requested review from
SLTozer,
OCHyams,
dwblaikie and
jalopezg-git
|
@llvm/pr-subscribers-backend-webassembly @llvm/pr-subscribers-debuginfo Author: Carlos Alberto Enciso (CarlosAlbertoEnciso) ChangesFixes an incorrect 'REQUIRES' in test case. REQUIRES: webassembly-registered-target Full diff: https://github.com/llvm/llvm-project/pull/145848.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/WebAssembly/wasm-32bit-tombstone.s b/llvm/test/tools/llvm-debuginfo-analyzer/WebAssembly/wasm-32bit-tombstone.s
index 3e1c1016c9aee..3609b3c8ecc3e 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/WebAssembly/wasm-32bit-tombstone.s
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/WebAssembly/wasm-32bit-tombstone.s
@@ -1,4 +1,4 @@
-# REQUIRES: x86-registered-target
+# REQUIRES: webassembly-registered-target
# Test that DWARF tombstones are correctly detected/respected in wasm
# 32 bit object files.
|
CarlosAlbertoEnciso
added
tools:llvm-debuginfo-analyzer
debuginfo
and removed
debuginfo
labels
|
@dyung Thanks for your approval. |
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…case (llvm#145848) Fixes an incorrect 'REQUIRES' in test case. The correct value should be: REQUIRES: webassembly-registered-target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect 'REQUIRES' in test case.
The correct value should be:
REQUIRES: webassembly-registered-target