Skip to content

[TTI] getInstructionCost - consistently treat all undef/poison shuffle masks as free #146039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
+23 −0
Merged

[TTI] getInstructionCost - consistently treat all undef/poison shuffle masks as free #146039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,6 +1534,10 @@ class TargetTransformInfoImplCRTPBase : public TargetTransformInfoImplBase {
ArrayRef<int> Mask = Shuffle->getShuffleMask();
int NumSubElts, SubIndex;

// Treat undef/poison mask as free (no matter the length).
if (all_of(Mask, [](int M) { return M < 0; }))
return TTI::TCC_Free;

// TODO: move more of this inside improveShuffleKindFromMask.
if (Shuffle->changesLength()) {
// Treat a 'subvector widening' as a free shuffle.
Expand Down
19 changes: 19 additions & 0 deletions llvm/test/Analysis/CostModel/X86/alternate-shuffle-cost.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,3 +758,22 @@ define <32 x i8> @test_v32i8_3(<32 x i8> %a, <32 x i8> %b) {
%1 = shufflevector <32 x i8> %a, <32 x i8> %b, <32 x i32> <i32 0, i32 1, i32 2, i32 3, i32 36, i32 5, i32 38, i32 7, i32 40, i32 9, i32 42, i32 11, i32 44, i32 13, i32 46, i32 15, i32 48, i32 17, i32 50, i32 19, i32 52, i32 21, i32 54, i32 23, i32 56, i32 25, i32 58, i32 27, i32 60, i32 61, i32 62, i32 63>
ret <32 x i8> %1
}

; Treat all undef/poison shuffle masks as free.
define <2 x i32> @test_v2i32_poison(<2 x i32> %a0, <2 x i32> %a1) {
; CHECK-LABEL: 'test_v2i32_poison'
; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: %s = shufflevector <2 x i32> %a0, <2 x i32> %a1, <2 x i32> poison
; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: ret <2 x i32> %s
;
%s = shufflevector <2 x i32> %a0, <2 x i32> %a1, <2 x i32> poison
ret <2 x i32> %s
}

define <4 x float> @test_v4f32_v2f32_poison(<2 x float> %a0, <2 x float> %a1) {
; CHECK-LABEL: 'test_v4f32_v2f32_poison'
; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: %s = shufflevector <2 x float> %a0, <2 x float> %a1, <4 x i32> poison
; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: ret <4 x float> %s
;
%s = shufflevector <2 x float> %a0, <2 x float> %a1, <4 x i32> poison
ret <4 x float> %s
}
Loading