[Arm] Fix UAF in ARMConstantIslandPass #146232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6
|
@llvm/pr-subscribers-backend-arm Author: Qinkun Bao (qinkunbao) Changes#146198 changes to Unfortunately, they are not NFC and causes the buildbot error. e.g., Full diff: https://github.com/llvm/llvm-project/pull/146232.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp b/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
index e72aa8ef051cd..ca3dc15ff3ad6 100644
--- a/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
+++ b/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
@@ -476,8 +476,8 @@ bool ARMConstantIslands::runOnMachineFunction(MachineFunction &mf) {
LLVM_DEBUG(dbgs() << "Beginning BR iteration #" << NoBRIters << '\n');
bool BRChange = false;
- for (ImmBranch &Br : ImmBranches)
- BRChange |= fixupImmediateBr(Br);
+ for (unsigned i = 0, e = ImmBranches.size(); i != e; ++i)
+ BRChange |= fixupImmediateBr(ImmBranches[i]);
if (BRChange && ++NoBRIters > 30)
report_fatal_error("Branch Fix Up pass failed to converge!");
LLVM_DEBUG(dumpBBs());
|
qinkunbao
changed the title
|
I'm assuming this is fixupImmediateBr resizing the vector, can you use make_early_inc_range |
Created using spr 1.3.6
qinkunbao
deleted the
users/qinkunbao/spr/arm-fix-uaf-in-httpsgithubcomllvmllvm-projectpull146198
branch
|
Looks like it does not work. |
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
llvm#146198 changes ``` for (unsigned i = 0, e = ImmBranches.size(); i != e; ++i) BRChange |= fixupImmediateBr(ImmBranches[i]); ``` to ``` for (ImmBranch &Br : ImmBranches) BRChange |= fixupImmediateBr(Br); ``` Unfortunately, they are not NFC and cause the buildbot error. e.g., https://lab.llvm.org/buildbot/#/builders/24/builds/9943 https://lab.llvm.org/buildbot/#/builders/169/builds/12570 Use make_early_inc_range to fix the issue
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
llvm#146198 changes ``` for (unsigned i = 0, e = ImmBranches.size(); i != e; ++i) BRChange |= fixupImmediateBr(ImmBranches[i]); ``` to ``` for (ImmBranch &Br : ImmBranches) BRChange |= fixupImmediateBr(Br); ``` Unfortunately, they are not NFC and cause the buildbot error. e.g., https://lab.llvm.org/buildbot/#/builders/24/builds/9943 https://lab.llvm.org/buildbot/#/builders/169/builds/12570 Use make_early_inc_range to fix the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#146198 changes
to
Unfortunately, they are not NFC and cause the buildbot error. e.g.,
https://lab.llvm.org/buildbot/#/builders/24/builds/9943
https://lab.llvm.org/buildbot/#/builders/169/builds/12570
Use make_early_inc_range to fix the issue