Skip to content

[opt] Remove reference to new PM from description of optimization level flags #65169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

karka228
Copy link
Collaborator

@karka228 karka228 commented Sep 1, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This repository does not accept pull requests. Please follow http://llvm.org/docs/Contributing.html#how-to-submit-a-patch for contribution to LLVM.

@github-actions github-actions bot closed this Sep 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
@karka228
Copy link
Collaborator Author

karka228 commented Sep 2, 2023

The purpose of this review was more or less to try out the new GitHub Pull Requests way of working. However I seems to have done this before pull requests was enabled ... but now it seems like it is enabled. I try to reopen this.

@karka228 karka228 reopened this Sep 2, 2023
@karka228 karka228 requested a review from bjope September 3, 2023 05:44
@bjope bjope requested a review from aeubanks September 4, 2023 16:32
static cl::opt<bool>
OptLevelO0("O0", cl::desc("Optimization level 0. Similar to clang -O0. "
"Use -passes='default<O0>' for the new PM"));
"Same as -passes='default<O0>'"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeubanks: Me and @karka228 is testing the PullRequest funcitonality a bit with this simple adjustment of the options descriptions. So I tried out adding you as an additional reviewer.

Given the rules we got for mixing -O and -passes this new wording will highlight that -O is equivalent to the longer form using -passes. So I think this is a nice improvement.

@karka228 karka228 merged commit 931df0e into llvm:main Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants