[GlobalISel] Add constant-folding of FP binops to combiner. #65230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arsenm this PR is ready for review |
aemerson
force-pushed
the
eng/gisel/opts-series-1
branch
from
ccdb60c to
e18d3e0
Compare
aemerson
force-pushed
the
eng/gisel/opts-series-1
branch
from
e18d3e0 to
5bfc6a1
Compare
arsenm
reviewed
Sep 6, 2023
| @@ -2645,6 +2645,14 @@ void CombinerHelper::replaceInstWithConstant(MachineInstr &MI, APInt C) { | |||
| MI.eraseFromParent(); | |||
| } | |||
|
|
|||
| void CombinerHelper::replaceInstWithFConstant(MachineInstr &MI, ConstantFP *CFP) { | |||
| assert(MI.getNumDefs() == 1 && "Expected only one def?"); | |||
| APFloat C = CFP->getValueAPF(); | |||
There was a problem hiding this comment.
Don't really need this temporary copy
| void CombinerHelper::replaceInstWithFConstant(MachineInstr &MI, ConstantFP *CFP) { | ||
| assert(MI.getNumDefs() == 1 && "Expected only one def?"); | ||
| APFloat C = CFP->getValueAPF(); | ||
| Builder.setInstr(MI); |
There was a problem hiding this comment.
We should really just fix the combiner to always set the insert point before the apply
aemerson
force-pushed
the
eng/gisel/opts-series-1
branch
from
fad3cc7 to
34d91b6
Compare
|
I was waiting for you to approve before merging. |
For some reason GitHub makes it more difficult to find the approve without merge option |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.