Skip to content

[clang][MSExtentions] Fix invalid overload failure about the loss of __unaligned qualifier #65248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

hazohelet
Copy link
Member

Loss of __unaligned qualifier does not invalidate overload candidates.
This fixes a regression reported in https://reviews.llvm.org/D153690

`__unaligned` qualifier

Loss of `__unaligned` qualifier does not invalidate overload
candidates.
This fixes a regression reported in https://reviews.llvm.org/D153690
@hazohelet hazohelet added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Sep 4, 2023
@hazohelet hazohelet requested a review from a team as a code owner September 4, 2023 08:12
@cor3ntin
Copy link
Contributor

cor3ntin commented Sep 4, 2023

Looks good to me but can you add a release note?
This was landed before RC1 and I'm not sure it qualifies for a backport at this stage (@AaronBallman @tru)

Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I think this can be held out of 17.0.0 but would be fine to backport to a later 17.x release if desired.

@hazohelet hazohelet merged commit cf51876 into llvm:main Sep 8, 2023
@hazohelet hazohelet deleted the unaligned branch September 13, 2023 09:02
qihangkong pushed a commit to rvgpu/llvm that referenced this pull request Apr 18, 2024
…`__unaligned` qualifier (#65248)

Loss of `__unaligned` qualifier does not invalidate overload candidates.
This fixes a regression reported in https://reviews.llvm.org/D153690

Reviewed By: cor3ntin, AaronBallman
PR: llvm/llvm-project#65248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants