Skip to content

[libc++][doc] Add warning about limitation of --fresh in boostrapping build #65265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

hawkinsw
Copy link
Contributor

@hawkinsw hawkinsw commented Sep 4, 2023

Add a warning to the Building Libcxx documentation about the limitations of the utility of --fresh at the top level.

… build

Add a warning to the `Building Libcxx` documentation about the
limitations of the utility of `--fresh` at the top level.

Signed-off-by: Will Hawkins <[email protected]>
@hawkinsw hawkinsw requested a review from a team as a code owner September 4, 2023 14:43
@hawkinsw
Copy link
Contributor Author

hawkinsw commented Sep 4, 2023

I hope that my lost time saves someone else!

cc @ldionne @EricWF (based on git-blame -- sorry if I inaccurately tagged!).

@philnik777 philnik777 added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 4, 2023
@ldionne
Copy link
Member

ldionne commented Sep 5, 2023

LGTM with a small nitpick.

@ldionne
Copy link
Member

ldionne commented Sep 6, 2023

@hawkinsw I have the option to squash and merge on your behalf here but it says the commit will be authored by [email protected]. I assume that's not what you want right (i.e. that's me misunderstanding how to use Github properly)?

@hawkinsw
Copy link
Contributor Author

hawkinsw commented Sep 6, 2023

@hawkinsw I have the option to squash and merge on your behalf here but it says the commit will be authored by [email protected]. I assume that's not what you want right (i.e. that's me misunderstanding how to use Github properly)?

You are correct, that's not what I want. I am sorry that I obviously failed to understand how the new workflow works. I will attempt to figure it out and @ you when I have resolved it. I am sorry for all the pain for such a simple fix. I hope that the bigger change I am working on (implementing stride_view) will make up for it!

Thanks for your help!

@hawkinsw
Copy link
Contributor Author

hawkinsw commented Sep 6, 2023

@ldionne I believe that I have fixed it now! You should see a drop-down that asks which email to associate with the commit. I would prefer [email protected]. Thank you for your patience!!

PS: In case you are wondering, the cause of this problem was that I had my verified email addresses set to hidden in my GitHub profile. As a result, GitHub was attempting to keep people from seeing my full address in public in the commit log. That is a nice feature, but the UI seems a little odd. I hope that information helps if you run into similar issues in the transition to GitHub workflows.

@ldionne ldionne merged commit f00e0f2 into llvm:main Sep 7, 2023
@ldionne
Copy link
Member

ldionne commented Sep 7, 2023

Thanks for the explanation, this is good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants