-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc++][doc] Add warning about limitation of --fresh in boostrapping build #65265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… build Add a warning to the `Building Libcxx` documentation about the limitations of the utility of `--fresh` at the top level. Signed-off-by: Will Hawkins <[email protected]>
LGTM with a small nitpick. |
…rapping build Add linebreak, per @ldionne's feedback.
@hawkinsw I have the option to squash and merge on your behalf here but it says the commit will be authored by [email protected]. I assume that's not what you want right (i.e. that's me misunderstanding how to use Github properly)? |
You are correct, that's not what I want. I am sorry that I obviously failed to understand how the new workflow works. I will attempt to figure it out and @ you when I have resolved it. I am sorry for all the pain for such a simple fix. I hope that the bigger change I am working on (implementing Thanks for your help! |
@ldionne I believe that I have fixed it now! You should see a drop-down that asks which email to associate with the commit. I would prefer PS: In case you are wondering, the cause of this problem was that I had my verified email addresses set to hidden in my GitHub profile. As a result, GitHub was attempting to keep people from seeing my full address in public in the commit log. That is a nice feature, but the UI seems a little odd. I hope that information helps if you run into similar issues in the transition to GitHub workflows. |
Thanks for the explanation, this is good to know! |
Add a warning to the
Building Libcxx
documentation about the limitations of the utility of--fresh
at the top level.