[clang][doc] Don't escape _ in .rst files. #65277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current generated ClangCommandLineReference.rst unconditionally escapes underscores. This leads odd output on the website https://clang.llvm.org/docs/ClangCommandLineReference.html For example -fchar8\_t, -fno-char8\_t Whether an underscore should be escaped depends on the state. Currently the escape routine doesn't keep track of the state and currently underscores are not used in places where they need to be escaped. Therefore remove the underscore from the list of escaped characters.
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
The current generated ClangCommandLineReference.rst unconditionally escapes underscores. This leads odd output on the website https://clang.llvm.org/docs/ClangCommandLineReference.html For example -fchar8\_t, -fno-char8\_t Whether an underscore should be escaped depends on the state. Currently the escape routine doesn't keep track of the state and currently underscores are not used in places where they need to be escaped. Therefore remove the underscore from the list of escaped characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generated ClangCommandLineReference.rst unconditionally escapes underscores. This leads odd output on the website https://clang.llvm.org/docs/ClangCommandLineReference.html
For example
-fchar8_t, -fno-char8_t
Whether an underscore should be escaped depends on the state. Currently the escape routine doesn't keep track of the state and currently underscores are not used in places where they need to be escaped. Therefore remove the underscore from the list of escaped characters.